You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jose-torres <gi...@git.apache.org> on 2018/01/22 18:58:50 UTC

[GitHub] spark pull request #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

GitHub user jose-torres opened a pull request:

    https://github.com/apache/spark/pull/20351

    [SPARK-23014][SS] Fully remove V1 memory sink.

    ## What changes were proposed in this pull request?
    
    Fully remove the V1 memory sink, now that all kinds of execution support the V2 version.
    
    ## How was this patch tested?
    
    existing unit tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jose-torres/spark v2-sink

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20351
    
----
commit 9b79c1c9c62209aad91dccc1f5f15e449d12df6d
Author: Jose Torres <jo...@...>
Date:   2018-01-05T21:27:23Z

    remove v1 sink

commit c75190bc027b3730f36ccda4d1d6c89f9f9acb85
Author: Jose Torres <jo...@...>
Date:   2018-01-22T18:56:11Z

    remove v2 sink from new tests

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86493/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by jose-torres <gi...@git.apache.org>.

Github user jose-torres commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #87271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87271/testReport)** for PR 20351 at commit [`efcf03d`](https://github.com/apache/spark/commit/efcf03d47bda6c9e0c797d7415d20ae2534db393).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by jose-torres <gi...@git.apache.org>.

Github user jose-torres commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    It says "fails PySpark unit tests", but the result page says "0 failures (±0)". I don't know if there's anything I can do to investigate this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #87410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87410/testReport)** for PR 20351 at commit [`6059a7f`](https://github.com/apache/spark/commit/6059a7f22f59f30030d508c3469fade58491da72).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87271/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #86493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86493/testReport)** for PR 20351 at commit [`c75190b`](https://github.com/apache/spark/commit/c75190bc027b3730f36ccda4d1d6c89f9f9acb85).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #86493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86493/testReport)** for PR 20351 at commit [`c75190b`](https://github.com/apache/spark/commit/c75190bc027b3730f36ccda4d1d6c89f9f9acb85).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87406/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #4097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4097/testReport)** for PR 20351 at commit [`efcf03d`](https://github.com/apache/spark/commit/efcf03d47bda6c9e0c797d7415d20ae2534db393).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `class MemoryStreamDataReaderFactory(records: Array[UnsafeRow])`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #87410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87410/testReport)** for PR 20351 at commit [`6059a7f`](https://github.com/apache/spark/commit/6059a7f22f59f30030d508c3469fade58491da72).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #4098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4098/testReport)** for PR 20351 at commit [`efcf03d`](https://github.com/apache/spark/commit/efcf03d47bda6c9e0c797d7415d20ae2534db393).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `class MemoryStreamDataReaderFactory(records: Array[UnsafeRow])`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #86491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86491/testReport)** for PR 20351 at commit [`c75190b`](https://github.com/apache/spark/commit/c75190bc027b3730f36ccda4d1d6c89f9f9acb85).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #87406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87406/testReport)** for PR 20351 at commit [`efcf03d`](https://github.com/apache/spark/commit/efcf03d47bda6c9e0c797d7415d20ae2534db393).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #4097 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4097/testReport)** for PR 20351 at commit [`efcf03d`](https://github.com/apache/spark/commit/efcf03d47bda6c9e0c797d7415d20ae2534db393).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #4098 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4098/testReport)** for PR 20351 at commit [`efcf03d`](https://github.com/apache/spark/commit/efcf03d47bda6c9e0c797d7415d20ae2534db393).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #87406 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87406/testReport)** for PR 20351 at commit [`efcf03d`](https://github.com/apache/spark/commit/efcf03d47bda6c9e0c797d7415d20ae2534db393).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `class MemoryStreamDataReaderFactory(records: Array[UnsafeRow])`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87410/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20351: [SPARK-23014][SS] Fully remove V1 memory sink.

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20351
  
    **[Test build #87271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87271/testReport)** for PR 20351 at commit [`efcf03d`](https://github.com/apache/spark/commit/efcf03d47bda6c9e0c797d7415d20ae2534db393).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `class MemoryStreamDataReaderFactory(records: Array[UnsafeRow])`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org