You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/17 08:48:45 UTC

[GitHub] [iceberg] dilipbiswal edited a comment on pull request #1947: Spark MERGE INTO Support (copy-on-write implementation)

dilipbiswal edited a comment on pull request #1947:
URL: https://github.com/apache/iceberg/pull/1947#issuecomment-761754092


   @rdblue @aokolnychyi 
   I have addressed most of the comments except one that i had trouble interpreting. I have marked some TODOs in the code for the ones that i will follow-up on. Here are the list:
   1. Pushdown local predicates from merge join condition into the dynamic file filter plan. (I am testing this at the moment)
   2. Resolve _file column in an unambiguous fashion.
   3. Optimize delete projection to either 1. set null 2. empty row 3. constant row.
   4. Move tests to the test file created by Anton for merge.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org