You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/23 22:36:25 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9641: [fix] Fixing regression from #9161
john-bodley opened a new pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Fixing a regression introduced in https://github.com/apache/incubator-superset/pull/9161 as `tests.test_app` is a requirement if running only the tests in the `sqla_models_tests.py` file.
This PR also ensures that the `tox.ini` commands are in alphabetical order.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Ran,
```
tox -e py36-sqlite -- tests/sqla_models_tests.py
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @etr2460 @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
+ Coverage 70.52% 70.56% +0.03%
==========================================
Files 574 182 -392
Lines 30152 17700 -12452
Branches 3060 0 -3060
==========================================
- Hits 21265 12490 -8775
+ Misses 8776 5210 -3566
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| [...ontend/src/dashboard/components/dnd/DragHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnSGFuZGxlLmpzeA==) | | |
| [.../dashboard/util/charts/getEffectiveExtraFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRFZmZlY3RpdmVFeHRyYUZpbHRlcnMuanM=) | | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | | |
| [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | | |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | | |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | | |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | | |
| ... and [382 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...6c199d9](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
- Coverage 70.52% 70.31% -0.22%
==========================================
Files 574 182 -392
Lines 30152 17700 -12452
Branches 3060 0 -3060
==========================================
- Hits 21265 12445 -8820
+ Misses 8776 5255 -3521
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.31% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.37% <0.00%> (-0.16%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | | |
| ... and [391 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...f5b047f](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
- Coverage 70.52% 70.49% -0.03%
==========================================
Files 574 182 -392
Lines 30152 17700 -12452
Branches 3060 0 -3060
==========================================
- Hits 21265 12478 -8787
+ Misses 8776 5222 -3554
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.49% <ø> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | | |
| [superset-frontend/src/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | | |
| [...hboard/util/getChartAndLabelComponentIdFromPath.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0QW5kTGFiZWxDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| [superset-frontend/src/modules/AnnotationTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvQW5ub3RhdGlvblR5cGVzLmpz) | | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | | |
| [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...6c199d9](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **decrease** coverage by `6.47%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
- Coverage 70.52% 64.04% -6.48%
==========================================
Files 574 526 -48
Lines 30152 28858 -1294
Branches 3060 2753 -307
==========================================
- Hits 21265 18483 -2782
- Misses 8776 10192 +1416
- Partials 111 183 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.71% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.59% <0.00%> (-78.17%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...f5b047f](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **decrease** coverage by `6.79%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
- Coverage 70.52% 63.72% -6.80%
==========================================
Files 574 526 -48
Lines 30152 28858 -1294
Branches 3060 2753 -307
==========================================
- Hits 21265 18391 -2874
- Misses 8776 10273 +1497
- Partials 111 194 +83
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.88% <ø> (-0.82%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.59% <0.00%> (-78.17%)` | :arrow_down: |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...f5b047f](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **decrease** coverage by `6.79%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
- Coverage 70.52% 63.72% -6.80%
==========================================
Files 574 526 -48
Lines 30152 28858 -1294
Branches 3060 2753 -307
==========================================
- Hits 21265 18391 -2874
- Misses 8776 10273 +1497
- Partials 111 194 +83
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.88% <ø> (-0.82%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.59% <0.00%> (-78.17%)` | :arrow_down: |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...6c199d9](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#discussion_r414307005
##########
File path: tox.ini
##########
@@ -99,6 +91,15 @@ setenv =
SUPERSET_CONFIG = tests.superset_test_config_sqllab_backend_persist
SUPERSET_HOME = {envtmpdir}
+[testenv:docs]
+commands =
+ cp -r superset-frontend/images/ docs/_static/images/
Review comment:
This copy statement should now be removed, as we've replaced it with a symlink (I forgot to do this fix in `tox.ini` as CI isn' t using this anymore)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
=======================================
Coverage 70.52% 70.52%
=======================================
Files 574 574
Lines 30152 30152
Branches 3060 3060
=======================================
Hits 21265 21265
Misses 8776 8776
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.71% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `58.76% <ø> (ø)` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...6c199d9](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
- Coverage 70.52% 70.49% -0.03%
==========================================
Files 574 182 -392
Lines 30152 17700 -12452
Branches 3060 0 -3060
==========================================
- Hits 21265 12478 -8787
+ Misses 8776 5222 -3554
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.49% <ø> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | | |
| [...rontend/src/dashboard/util/componentIsResizable.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLmpz) | | |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | | |
| [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | | |
| [...perset-frontend/src/dashboard/util/isValidChild.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC5qcw==) | | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | | |
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...f5b047f](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
- Coverage 70.52% 70.31% -0.22%
==========================================
Files 574 182 -392
Lines 30152 17700 -12452
Branches 3060 0 -3060
==========================================
- Hits 21265 12445 -8820
+ Misses 8776 5255 -3521
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.31% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.37% <0.00%> (-0.16%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | | |
| ... and [391 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...6c199d9](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
+ Coverage 70.52% 70.56% +0.03%
==========================================
Files 574 182 -392
Lines 30152 17700 -12452
Branches 3060 0 -3060
==========================================
- Hits 21265 12490 -8775
+ Misses 8776 5210 -3566
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | | |
| [...ntend/src/explore/components/AdhocFilterOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlck9wdGlvbi5qc3g=) | | |
| [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | | |
| [...-frontend/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrU2NhdHRlci5qcw==) | | |
| [...frontend/src/components/BootstrapSliderWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQm9vdHN0cmFwU2xpZGVyV3JhcHBlci5qc3g=) | | |
| [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | | |
| [...t-frontend/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | | |
| [.../src/explore/components/controls/SliderControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TbGlkZXJDb250cm9sLmpzeA==) | | |
| [...et-frontend/src/explore/controlPanels/sections.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9zZWN0aW9ucy5qc3g=) | | |
| ... and [382 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...6c199d9](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
=======================================
Coverage 70.52% 70.52%
=======================================
Files 574 574
Lines 30152 30152
Branches 3060 3060
=======================================
Hits 21265 21265
Misses 8776 8776
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.71% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `58.76% <ø> (ø)` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...f5b047f](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9641: [fix] Fixing regression from #9161
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9641:
URL: https://github.com/apache/incubator-superset/pull/9641#issuecomment-618708603
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=h1) Report
> Merging [#9641](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6cedaaa879348aca49a520793bb20e63d152a1f&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9641/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9641 +/- ##
==========================================
+ Coverage 70.52% 70.56% +0.03%
==========================================
Files 574 182 -392
Lines 30152 17700 -12452
Branches 3060 0 -3060
==========================================
- Hits 21265 12490 -8775
+ Misses 8776 5210 -3566
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | | |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | | |
| [superset-frontend/src/components/ErrorBoundary.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS5qc3g=) | | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | | |
| [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | | |
| [...rc/dashboard/components/FilterIndicatorTooltip.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvclRvb2x0aXAuanN4) | | |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | | |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | | |
| ... and [382 more](https://codecov.io/gh/apache/incubator-superset/pull/9641/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=footer). Last update [a6cedaa...f5b047f](https://codecov.io/gh/apache/incubator-superset/pull/9641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org