You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by ji...@apache.org on 2012/08/01 14:02:00 UTC

svn commit: r1367943 - /apr/apr/trunk/build/apr_hints.m4

Author: jim
Date: Wed Aug  1 12:02:00 2012
New Revision: 1367943

URL: http://svn.apache.org/viewvc?rev=1367943&view=rev
Log:
Update for Mountain Lion / OSX 10.8 / Darwin 12.x

Modified:
    apr/apr/trunk/build/apr_hints.m4

Modified: apr/apr/trunk/build/apr_hints.m4
URL: http://svn.apache.org/viewvc/apr/apr/trunk/build/apr_hints.m4?rev=1367943&r1=1367942&r2=1367943&view=diff
==============================================================================
--- apr/apr/trunk/build/apr_hints.m4 (original)
+++ apr/apr/trunk/build/apr_hints.m4 Wed Aug  1 12:02:00 2012
@@ -203,7 +203,7 @@ dnl	       # Not a problem in 10.20.  Ot
                 APR_SETIFNULL(ac_cv_func_kqueue, [no]) 
                 APR_SETIFNULL(ac_cv_func_poll, [no]) # See issue 34332
             ;;
-            *-apple-darwin1[[01]].*)
+            *-apple-darwin1[[012]].*)
                 APR_ADDTO(CPPFLAGS, [-DDARWIN_10])
             ;;
         esac



Re: svn commit: r1367943 - /apr/apr/trunk/build/apr_hints.m4

Posted by Jim Jagielski <ji...@apache.org>.
Depends... I can see likely saying that with apr-1.5 and apr-trunk
we "assume" that we only support OSX 10.6+

On Aug 1, 2012, at 12:29 PM, William A. Rowe Jr. <wr...@rowe-clan.net> wrote:

> On 8/1/2012 5:02 AM, jim@apache.org wrote:
>> Author: jim
>> Date: Wed Aug  1 12:02:00 2012
>> New Revision: 1367943
>> 
>> URL: http://svn.apache.org/viewvc?rev=1367943&view=rev
>> Log:
>> Update for Mountain Lion / OSX 10.8 / Darwin 12.x
> 
>> -            *-apple-darwin1[[01]].*)
>> +            *-apple-darwin1[[012]].*)
>>                 APR_ADDTO(CPPFLAGS, [-DDARWIN_10])
> 
> Somehow, we keep supporting new Linux/Solaris/AIX kernels without such
> nonsense, and pre-support the 'next' release without additional effort.
> 
> Is the mistake that we should have special-cased the -apple-darwin?.
> scenarios and then have one generic -apple-darwin* for any more-recent
> version, until there is a breaking change?
> 
> 


Re: svn commit: r1367943 - /apr/apr/trunk/build/apr_hints.m4

Posted by Jim Jagielski <ji...@apache.org>.
Depends... I can see likely saying that with apr-1.5 and apr-trunk
we "assume" that we only support OSX 10.6+

On Aug 1, 2012, at 12:29 PM, William A. Rowe Jr. <wr...@rowe-clan.net> wrote:

> On 8/1/2012 5:02 AM, jim@apache.org wrote:
>> Author: jim
>> Date: Wed Aug  1 12:02:00 2012
>> New Revision: 1367943
>> 
>> URL: http://svn.apache.org/viewvc?rev=1367943&view=rev
>> Log:
>> Update for Mountain Lion / OSX 10.8 / Darwin 12.x
> 
>> -            *-apple-darwin1[[01]].*)
>> +            *-apple-darwin1[[012]].*)
>>                 APR_ADDTO(CPPFLAGS, [-DDARWIN_10])
> 
> Somehow, we keep supporting new Linux/Solaris/AIX kernels without such
> nonsense, and pre-support the 'next' release without additional effort.
> 
> Is the mistake that we should have special-cased the -apple-darwin?.
> scenarios and then have one generic -apple-darwin* for any more-recent
> version, until there is a breaking change?
> 
> 


Re: svn commit: r1367943 - /apr/apr/trunk/build/apr_hints.m4

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 8/1/2012 5:02 AM, jim@apache.org wrote:
> Author: jim
> Date: Wed Aug  1 12:02:00 2012
> New Revision: 1367943
> 
> URL: http://svn.apache.org/viewvc?rev=1367943&view=rev
> Log:
> Update for Mountain Lion / OSX 10.8 / Darwin 12.x

> -            *-apple-darwin1[[01]].*)
> +            *-apple-darwin1[[012]].*)
>                  APR_ADDTO(CPPFLAGS, [-DDARWIN_10])

Somehow, we keep supporting new Linux/Solaris/AIX kernels without such
nonsense, and pre-support the 'next' release without additional effort.

Is the mistake that we should have special-cased the -apple-darwin?.
scenarios and then have one generic -apple-darwin* for any more-recent
version, until there is a breaking change?