You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/06/11 21:37:45 UTC
Review Request 67513: Added a master flag to configure minimum
allocatable resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Greg Mann.
Repository: mesos
Description
-------
This patch adds a new master flag `min_allocatable_resources`.
It specifies one or more resources quantities that define the
minimum allocatable resources for the allocator. The allocator
will only offer resources that are more than at least one of
the specified resources.
Diffs
-----
include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
src/tests/api_tests.cpp 15dbbc1b3efe8e139a2c6b1a4a7087743dbe950c
src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
Diff: https://reviews.apache.org/r/67513/diff/1/
Testing
-------
make check
Fixed all existing tests.
Dedicate test added in a subsequent patch.
Thanks,
Meng Zhu
Re: Review Request 67513: Added a master flag to configure minimum
allocatable resources.
Posted by Greg Mann <gr...@mesosphere.io>.
> On June 19, 2018, 7:18 p.m., Greg Mann wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 179-183 (original), 179-192 (patched)
> > <https://reviews.apache.org/r/67513/diff/2/?file=2041128#file2041128line179>
> >
> > Do we have any tests which verify that the allocator's min. allocatable resources check is actually enforced?
lol it's in the following patch, my bad :)
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/#review205011
-----------------------------------------------------------
On June 15, 2018, 10:02 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67513/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 10:02 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new master flag `min_allocatable_resources`.
> It specifies one or more resources quantities that define the
> minimum allocatable resources for the allocator. The allocator
> will only offer resources that are more than at least one of
> the specified resources.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
> src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
> src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
> src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
> src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
> src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
> src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
> src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c
> src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
> src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
> src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
> src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
>
>
> Diff: https://reviews.apache.org/r/67513/diff/2/
>
>
> Testing
> -------
>
> make check
> Fixed all existing tests.
> Dedicate test added in a subsequent patch.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67513: Added a master flag to configure minimum
allocatable resources.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On June 19, 2018, 12:18 p.m., Greg Mann wrote:
> > src/master/flags.cpp
> > Lines 479 (patched)
> > <https://reviews.apache.org/r/67513/diff/2/?file=2041124#file2041124line479>
> >
> > Could you update the configuration documentation for the master as well?
Done.
> On June 19, 2018, 12:18 p.m., Greg Mann wrote:
> > src/master/flags.cpp
> > Lines 481-487 (patched)
> > <https://reviews.apache.org/r/67513/diff/2/?file=2041124#file2041124line481>
> >
> > How about:
> >
> > ```
> > One or more sets of resources that define the minimum allocatable
> > resources for the allocator. The allocator will only offer resources
> > that contain at least one of the specified sets. The resources in each
> > set should be delimited by semicolons, and the sets should be delimited
> > by the pipe character.
> > (Example: `disk:1|cpu:1;mem:32` configures the allocator to only offer
> > resources if they contain a disk resource of at least 1 megabyte, or
> > if they contain both 1 cpu and 32 megabytes of memory.)
> > ```
Thanks for the suggestion!
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/#review205011
-----------------------------------------------------------
On June 19, 2018, 2:39 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67513/
> -----------------------------------------------------------
>
> (Updated June 19, 2018, 2:39 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new master flag `min_allocatable_resources`.
> It specifies one or more resources quantities that define the
> minimum allocatable resources for the allocator. The allocator
> will only offer resources that are more than at least one of
> the specified resources.
>
>
> Diffs
> -----
>
> docs/configuration/master.md 2ba612b319f28c60e8a73455952293db81c78528
> include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
> src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
> src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
> src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
> src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
> src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
> src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
> src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c
> src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
> src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
> src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
> src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
>
>
> Diff: https://reviews.apache.org/r/67513/diff/3/
>
>
> Testing
> -------
>
> make check
> Fixed all existing tests.
> Dedicate test added in a subsequent patch.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67513: Added a master flag to configure minimum
allocatable resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/#review205011
-----------------------------------------------------------
src/master/flags.cpp
Lines 479 (patched)
<https://reviews.apache.org/r/67513/#comment287862>
Could you update the configuration documentation for the master as well?
src/master/flags.cpp
Lines 481-487 (patched)
<https://reviews.apache.org/r/67513/#comment287861>
How about:
```
One or more sets of resources that define the minimum allocatable
resources for the allocator. The allocator will only offer resources
that contain at least one of the specified sets. The resources in each
set should be delimited by semicolons, and the sets should be delimited
by the pipe character.
(Example: `disk:1|cpu:1;mem:32` configures the allocator to only offer
resources if they contain a disk resource of at least 1 megabyte, or
if they contain both 1 cpu and 32 megabytes of memory.)
```
src/tests/hierarchical_allocator_tests.cpp
Lines 179-183 (original), 179-192 (patched)
<https://reviews.apache.org/r/67513/#comment287871>
Do we have any tests which verify that the allocator's min. allocatable resources check is actually enforced?
- Greg Mann
On June 15, 2018, 10:02 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67513/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 10:02 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new master flag `min_allocatable_resources`.
> It specifies one or more resources quantities that define the
> minimum allocatable resources for the allocator. The allocator
> will only offer resources that are more than at least one of
> the specified resources.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
> src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
> src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
> src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
> src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
> src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
> src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
> src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c
> src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
> src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
> src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
> src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
>
>
> Diff: https://reviews.apache.org/r/67513/diff/2/
>
>
> Testing
> -------
>
> make check
> Fixed all existing tests.
> Dedicate test added in a subsequent patch.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67513: Added a master flag to configure minimum
allocatable resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/#review205137
-----------------------------------------------------------
src/master/master.cpp
Lines 774-786 (patched)
<https://reviews.apache.org/r/67513/#comment288099>
Not indented far enough. I'll fix this while committing.
- Greg Mann
On June 20, 2018, 5:52 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67513/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 5:52 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new master flag `min_allocatable_resources`.
> It specifies one or more resources quantities that define the
> minimum allocatable resources for the allocator. The allocator
> will only offer resources that are more than at least one of
> the specified resources.
>
> Also fixed all related tests and updated documentation.
>
>
> Diffs
> -----
>
> docs/configuration/master.md 2ba612b319f28c60e8a73455952293db81c78528
> include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
> src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
> src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
> src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
> src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
> src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
> src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
> src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c
> src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
> src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
> src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
> src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
>
>
> Diff: https://reviews.apache.org/r/67513/diff/4/
>
>
> Testing
> -------
>
> make check
> Fixed all existing tests.
> Dedicate test added in a subsequent patch.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67513: Added a master flag to configure minimum
allocatable resources.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/
-----------------------------------------------------------
(Updated June 20, 2018, 10:52 a.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Changes
-------
Updated indentation and removed redundant move().
Bugs: MESOS-8935
https://issues.apache.org/jira/browse/MESOS-8935
Repository: mesos
Description (updated)
-------
This patch adds a new master flag `min_allocatable_resources`.
It specifies one or more resources quantities that define the
minimum allocatable resources for the allocator. The allocator
will only offer resources that are more than at least one of
the specified resources.
Also fixed all related tests and updated documentation.
Diffs (updated)
-----
docs/configuration/master.md 2ba612b319f28c60e8a73455952293db81c78528
include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c
src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
Diff: https://reviews.apache.org/r/67513/diff/4/
Changes: https://reviews.apache.org/r/67513/diff/3-4/
Testing
-------
make check
Fixed all existing tests.
Dedicate test added in a subsequent patch.
Thanks,
Meng Zhu
Re: Review Request 67513: Added a master flag to configure minimum
allocatable resources.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/#review205037
-----------------------------------------------------------
Fix it, then Ship it!
docs/configuration/master.md
Lines 210-218 (patched)
<https://reviews.apache.org/r/67513/#comment287920>
Indented too far, see other flag descriptions in this file.
- Greg Mann
On June 19, 2018, 9:39 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67513/
> -----------------------------------------------------------
>
> (Updated June 19, 2018, 9:39 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new master flag `min_allocatable_resources`.
> It specifies one or more resources quantities that define the
> minimum allocatable resources for the allocator. The allocator
> will only offer resources that are more than at least one of
> the specified resources.
>
>
> Diffs
> -----
>
> docs/configuration/master.md 2ba612b319f28c60e8a73455952293db81c78528
> include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
> src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
> src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
> src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
> src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
> src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
> src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
> src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c
> src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
> src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
> src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
> src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
>
>
> Diff: https://reviews.apache.org/r/67513/diff/3/
>
>
> Testing
> -------
>
> make check
> Fixed all existing tests.
> Dedicate test added in a subsequent patch.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67513: Added a master flag to configure minimum
allocatable resources.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/
-----------------------------------------------------------
(Updated June 19, 2018, 2:39 p.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Bugs: MESOS-8935
https://issues.apache.org/jira/browse/MESOS-8935
Repository: mesos
Description
-------
This patch adds a new master flag `min_allocatable_resources`.
It specifies one or more resources quantities that define the
minimum allocatable resources for the allocator. The allocator
will only offer resources that are more than at least one of
the specified resources.
Diffs (updated)
-----
docs/configuration/master.md 2ba612b319f28c60e8a73455952293db81c78528
include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c
src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
Diff: https://reviews.apache.org/r/67513/diff/3/
Changes: https://reviews.apache.org/r/67513/diff/2-3/
Testing
-------
make check
Fixed all existing tests.
Dedicate test added in a subsequent patch.
Thanks,
Meng Zhu
Re: Review Request 67513: Added a master flag to configure minimum
allocatable resources.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/
-----------------------------------------------------------
(Updated June 15, 2018, 3:02 p.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Changes
-------
Removed JSON input format.
Bugs: MESOS-8935
https://issues.apache.org/jira/browse/MESOS-8935
Repository: mesos
Description
-------
This patch adds a new master flag `min_allocatable_resources`.
It specifies one or more resources quantities that define the
minimum allocatable resources for the allocator. The allocator
will only offer resources that are more than at least one of
the specified resources.
Diffs (updated)
-----
include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
src/tests/api_tests.cpp 85635a8662469c7dbe4e77bb8da6eb450ec8f01c
src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
Diff: https://reviews.apache.org/r/67513/diff/2/
Changes: https://reviews.apache.org/r/67513/diff/1-2/
Testing
-------
make check
Fixed all existing tests.
Dedicate test added in a subsequent patch.
Thanks,
Meng Zhu
Re: Review Request 67513: Added a master flag to configure minimum
allocatable resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67513/#review204568
-----------------------------------------------------------
PASS: Mesos patch 67513 was successfully built and tested.
Reviews applied: `['67510', '67516', '67513']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67513
- Mesos Reviewbot Windows
On June 11, 2018, 9:37 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67513/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 9:37 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Bugs: MESOS-8935
> https://issues.apache.org/jira/browse/MESOS-8935
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new master flag `min_allocatable_resources`.
> It specifies one or more resources quantities that define the
> minimum allocatable resources for the allocator. The allocator
> will only offer resources that are more than at least one of
> the specified resources.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 647869286d46920b98521e219ce92c3260058c35
> src/master/allocator/mesos/allocator.hpp c453c015b234deff7efd00269da25dcec8cbf1ae
> src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
> src/master/flags.hpp 94b8ac2211180416190448b71ea9c81c6c0cd7fc
> src/master/flags.cpp cc3317ee5d740cb1d58b51ae00ceeb8d55754b9d
> src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2
> src/tests/allocator.hpp 341efa665ad0ce897e087fb8d73ec50fd041d559
> src/tests/api_tests.cpp 15dbbc1b3efe8e139a2c6b1a4a7087743dbe950c
> src/tests/hierarchical_allocator_tests.cpp c97b2ba0884a7ded867c2d80e4749de54c89b5e4
> src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d
> src/tests/master_quota_tests.cpp 94d85c5a4b70ef2bc4e8689b896fe99f3acfd4b9
> src/tests/reservation_tests.cpp 7d121bf56b913c3217dec00c57f81663e9831351
> src/tests/resource_offers_tests.cpp 54aafdb4258ad7713c5f1a59956e7f76f0e84d5b
> src/tests/slave_recovery_tests.cpp 2a92acc193b4db5001ae5bca53e7333ba7203210
>
>
> Diff: https://reviews.apache.org/r/67513/diff/1/
>
>
> Testing
> -------
>
> make check
> Fixed all existing tests.
> Dedicate test added in a subsequent patch.
>
>
> Thanks,
>
> Meng Zhu
>
>