You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/22 00:54:51 UTC

[kudu-CR] client: fix export target munging on Linux

Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/1866

to review the following change.

Change subject: client: fix export target munging on Linux
......................................................................

client: fix export target munging on Linux

Despite being good intentioned, commit fa6e943 fixed target munging on OS X
at the expense of regressing it on Linux. Specifically, "sed -i ''" yields
backup files with double single-quote suffixes in their names.

After extensive trial and error, the only in-place invocation of sed that'd
work for both platforms required duplicating the call to execute_process().
That's ugly, so here's an approach that foregoes in-place replacement.

Dan and I tested this on Linux and OS X. In both cases:
1. No backup cmake files were created, and
2. The actual replacement took place.

Change-Id: I3451258ff29670367a357111c43e3c27c6392622
---
M src/kudu/client/MungeExportedInstallTargets.cmake
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/1866/1
-- 
To view, visit http://gerrit.cloudera.org:8080/1866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3451258ff29670367a357111c43e3c27c6392622
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>