You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2017/11/16 00:40:32 UTC
[GitHub] spark pull request #19762: [SPARK-22535][PySpark] Sleep before killing the p...
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/19762
[SPARK-22535][PySpark] Sleep before killing the python worker in PythonRunner.MonitorThread
## What changes were proposed in this pull request?
`PythonRunner.MonitorThread` should give the task a little time to finish before forcibly killing the python worker. This will reduce the chance of the race condition a lot. I also improved the log a bit to find out the task to blame when it's stuck.
## How was this patch tested?
Jenkins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-22535
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19762
----
commit a1f054ba9aff2bef5caf4534ef56dfd5e22eb96e
Author: Shixiong Zhu <zs...@gmail.com>
Date: 2017-11-16T00:35:09Z
Sleep before killing the python worker in PythonRunner.MonitorThread
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19762
Thanks! merging to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/19762
cc @ueshin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19762: [SPARK-22535][PySpark] Sleep before killing the p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19762
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19762
**[Test build #83921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83921/testReport)** for PR 19762 at commit [`a1f054b`](https://github.com/apache/spark/commit/a1f054ba9aff2bef5caf4534ef56dfd5e22eb96e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19762
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19762
**[Test build #83925 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83925/testReport)** for PR 19762 at commit [`dffcb05`](https://github.com/apache/spark/commit/dffcb05e3c7b7ef0973769337092b2b7adbc7992).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19762
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19762
**[Test build #83925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83925/testReport)** for PR 19762 at commit [`dffcb05`](https://github.com/apache/spark/commit/dffcb05e3c7b7ef0973769337092b2b7adbc7992).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19762
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83925/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19762
**[Test build #83921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83921/testReport)** for PR 19762 at commit [`a1f054b`](https://github.com/apache/spark/commit/a1f054ba9aff2bef5caf4534ef56dfd5e22eb96e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19762: [SPARK-22535][PySpark] Sleep before killing the python w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19762
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83921/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org