You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/21 18:45:10 UTC
[GitHub] [arrow] austin3dickey opened a new pull request, #14691: ARROW-18374: [Go][CI][Benchmarking] Fix Go benchmark github info
austin3dickey opened a new pull request, #14691:
URL: https://github.com/apache/arrow/pull/14691
This PR fixes the Go benchmark script to work with recent `benchadapt` changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14691: ARROW-18374: [Go][CI][Benchmarking] Fix Go benchmark github info
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14691:
URL: https://github.com/apache/arrow/pull/14691#issuecomment-1324807402
Benchmark runs are scheduled for baseline = 42caa23b00c51388f27d27515411e94204b472dc and contender = 7198676ac4d69f0a10bc750647cab1f7fd12a7db. 7198676ac4d69f0a10bc750647cab1f7fd12a7db is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/70b27413d95b409ebf77bbbee387b6e9...5ba30a6e7e7d4a5baaa1b3c9f6935281/)
[Finished :arrow_down:0.07% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1d0b14127b5a42f7a904ff11dac8fff9...9dae8e838e0f4e28bdbeaf0cd48dd186/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0c5402fa7acc41b187e832c3e2c894a7...08c7c161a9444b61bb00ef36e1297bfd/)
[Finished :arrow_down:0.14% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2937674028eb412d974a8ea8d63c3b0f...dc003fc8347149e29623174d415ba31d/)
Buildkite builds:
[Finished] [`7198676a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1900)
[Finished] [`7198676a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1922)
[Finished] [`7198676a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1891)
[Finished] [`7198676a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1914)
[Finished] [`42caa23b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1899)
[Finished] [`42caa23b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1921)
[Finished] [`42caa23b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1890)
[Finished] [`42caa23b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1913)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #14691: ARROW-18374: [Go][CI][Benchmarking] Fix Go benchmark github info
Posted by GitBox <gi...@apache.org>.
zeroshade merged PR #14691:
URL: https://github.com/apache/arrow/pull/14691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14691: ARROW-18374: [Go][CI][Benchmarking] Fix Go benchmark github info
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14691:
URL: https://github.com/apache/arrow/pull/14691#issuecomment-1322498539
https://issues.apache.org/jira/browse/ARROW-18374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #14691: ARROW-18374: [Go][CI][Benchmarking] Fix Go benchmark github info
Posted by GitBox <gi...@apache.org>.
zeroshade commented on code in PR #14691:
URL: https://github.com/apache/arrow/pull/14691#discussion_r1028412855
##########
ci/scripts/go_bench_adapt.py:
##########
@@ -79,7 +79,11 @@ def _transform_results(self) -> List[BenchmarkResult]:
"params": '/'.join(pieces[1:]),
},
run_reason=RUN_REASON,
- github=None, # scrape info from cloned repo
+ github={
+ "repository": os.environ["GITHUB_REPOSITORY"],
+ "commit": os.environ["GITHUB_SHA"],
+ "pr_number": None, # we currently only run this on the default branch
Review Comment:
yea, it's something easy enough to grab from an Env var or to have passed in via the GHA itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] austin3dickey commented on a diff in pull request #14691: ARROW-18374: [Go][CI][Benchmarking] Fix Go benchmark github info
Posted by GitBox <gi...@apache.org>.
austin3dickey commented on code in PR #14691:
URL: https://github.com/apache/arrow/pull/14691#discussion_r1028409994
##########
ci/scripts/go_bench_adapt.py:
##########
@@ -79,7 +79,11 @@ def _transform_results(self) -> List[BenchmarkResult]:
"params": '/'.join(pieces[1:]),
},
run_reason=RUN_REASON,
- github=None, # scrape info from cloned repo
+ github={
+ "repository": os.environ["GITHUB_REPOSITORY"],
+ "commit": os.environ["GITHUB_SHA"],
+ "pr_number": None, # we currently only run this on the default branch
Review Comment:
If this ever changes, it will be important to scrape the PR number from a GHA environment variable. [This issue](https://github.com/actions/checkout/issues/58) has many suggestions on how to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org