You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:48:08 UTC
Review Request 65864: Updated mesos code with the new `os::spawn`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65864/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
`os::spawn`'s return type was changed from `int` to `Option<int>`, so
the code in mesos was changed accordingly.
Diffs
-----
src/linux/fs.cpp dae094224321c0974c705023daf076409049de51
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169
src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
Diff: https://reviews.apache.org/r/65864/diff/1/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 65864: Updated mesos code with the new `os::spawn`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On March 1, 2018, 3:13 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> >
> > Reviews applied: `['65839', '65861', '65862', '65840', '65841', '65863', '65842', '65864']`
> >
> > Failed command: `Start-MesosCITesting`
> >
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65864
> >
> > Relevant logs:
> >
> > - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65864/logs/mesos-tests-stdout.log):
> >
> > ```
> > [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (122 ms)
> > [----------] 9 tests from Endpoint/SlaveEndpointTest (1161 ms total)
> >
> > [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
> > [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
> > [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
> > [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
> > [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (42 ms)
> > [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (82 ms total)
> >
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest
> > [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
> > [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2452 ms)
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest (2477 ms total)
> >
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest
> > [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
> > [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2471 ms)
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest (2496 ms total)
> >
> > [----------] Global test environment tear-down
> > [==========] 915 tests from 90 test cases ran. (483944 ms total)
> > [ PASSED ] 914 tests.
> > [ FAILED ] 1 test, listed below:
> > [ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
> >
> > 1 FAILED TEST
> > YOU HAVE 211 DISABLED TESTS
> >
> > ```
> >
> > - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65864/logs/mesos-tests-stderr.log):
> >
> > ```
> > I0301 11:13:00.392838 3904 master.cpp:10258] Updating the state of task c089b288-d808-4c8c-9442-65a71ba36ab6 of framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
> > I0301 11:13:00.392838 7792 slave.cpp:3879] Shutting down framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000
> > I0301 11:13:00.393837 I0301 11:12:59.687856 8596 exec.cpp:162] Version: 1.6.0
> > I0301 11:12:59.715831 5672 exec.cpp:236] Executor registered on agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0
> > I0301 11:12:59.719864 2348 executor.cpp:176] Received SUBSCRIBED event
> > I0301 11:12:59.724831 2348 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
> > I0301 11:12:59.725832 2348 executor.cpp:176] Received LAUNCH event
> > I0301 11:12:59.730831 2348 executor.cpp:648] Starting task c089b288-d808-4c8c-9442-65a71ba36ab6
> > I0301 11:12:59.820832 2348 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
> > I0301 11:13:00.362879 2348 executor.cpp:661] Forked command at 7744
> > I0301 11:13:00.396836 8640 exec.cpp:445] Executor asked to shutdown
> > I0301 11:13:00.397835 2348 executor.cpp:176] Received SHUTDOWN event
> > I0301 11:13:00.397835 2348 executor.cpp:758] Shutting down
> > I0301 11:13:00.397835 2348 executor.cpp:868] Sending SIGTERM to process tree at pid 77792 slave.cpp:6586] Shutting down executor 'c089b288-d808-4c8c-9442-65a71ba36ab6' of framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000 at executor(1)@10.3.1.5:58360
> > I0301 11:13:00.395835 7792 slave.cpp:922] Agent terminating
> > W0301 11:13:00.395835 7792 slave.cpp:3875] Ignoring shutdown framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000 because it is terminating
> > I0301 11:13:00.395835 3904 master.cpp:10357] Removing task c089b288-d808-4c8c-9442-65a71ba36ab6 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000 on agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 at slave(398)@10.3.1.5:58339 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0301 11:13:00.398835 1376 containerizer.cpp:2338] Destroying container 6250952d-c4ad-42e8-a115-0c87830b89eb in RUNNING state
> > I0301 11:13:00.398835 2876 hierarchical.cpp:344] Removed framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000
> > I0301 11:13:00.398835 1376 containerizer.cpp:2952] Transitioning the state of container 6250952d-c4ad-42e8-a115-0c87830b89eb from RUNNING to DESTROYING
> > I0301 11:13:00.398835 3904 master.cpp:1306] Agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 at slave(398)@10.3.1.5:58339 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
> > I0301 11:13:00.399962 3904 master.cpp:3276] Disconnecting agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 at slave(398)@10.3.1.5:58339 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0301 11:13:00.400837 3904 master.cpp:3295] Deactivating agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 at slave(398)@10.3.1.5:58339 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0301 11:13:00.400837 240 hierarchical.cpp:766] Agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 deactivated
> > I0301 11:13:00.400837 1376 launcher.cpp:156] Asked to destroy container 6250952d-c4ad-42e8-a115-0c87830b89eb
> > I0301 11:13:00.416858 240 containerizer.cpp:2791] Container 6250952d-c4ad-42e8-a115-0c87830b89eb has exited
> > I0301 11:13:00.451861 9132 master.cpp:1149] Master terminating
> > I0301 11:13:00.453861 7972 hierarchical.cpp:609] Removed agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0
> > I0301 11:13:00.844225 1524 process.cpp:929] Stopped the socket accept loop
> > ```
This is known to be flaky.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65864/#review198443
-----------------------------------------------------------
On March 1, 2018, 1:48 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65864/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 1:48 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-4549
> https://issues.apache.org/jira/browse/MESOS-4549
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `os::spawn`'s return type was changed from `int` to `Option<int>`, so
> the code in mesos was changed accordingly.
>
>
> Diffs
> -----
>
> src/linux/fs.cpp dae094224321c0974c705023daf076409049de51
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169
> src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
>
>
> Diff: https://reviews.apache.org/r/65864/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65864: Updated mesos code with the new `os::spawn`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65864/#review198443
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65839', '65861', '65862', '65840', '65841', '65863', '65842', '65864']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65864
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65864/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (122 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1161 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (42 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (82 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2452 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2477 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2471 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2496 ms total)
[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (483944 ms total)
[ PASSED ] 914 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65864/logs/mesos-tests-stderr.log):
```
I0301 11:13:00.392838 3904 master.cpp:10258] Updating the state of task c089b288-d808-4c8c-9442-65a71ba36ab6 of framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0301 11:13:00.392838 7792 slave.cpp:3879] Shutting down framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000
I0301 11:13:00.393837 I0301 11:12:59.687856 8596 exec.cpp:162] Version: 1.6.0
I0301 11:12:59.715831 5672 exec.cpp:236] Executor registered on agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0
I0301 11:12:59.719864 2348 executor.cpp:176] Received SUBSCRIBED event
I0301 11:12:59.724831 2348 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0301 11:12:59.725832 2348 executor.cpp:176] Received LAUNCH event
I0301 11:12:59.730831 2348 executor.cpp:648] Starting task c089b288-d808-4c8c-9442-65a71ba36ab6
I0301 11:12:59.820832 2348 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0301 11:13:00.362879 2348 executor.cpp:661] Forked command at 7744
I0301 11:13:00.396836 8640 exec.cpp:445] Executor asked to shutdown
I0301 11:13:00.397835 2348 executor.cpp:176] Received SHUTDOWN event
I0301 11:13:00.397835 2348 executor.cpp:758] Shutting down
I0301 11:13:00.397835 2348 executor.cpp:868] Sending SIGTERM to process tree at pid 77792 slave.cpp:6586] Shutting down executor 'c089b288-d808-4c8c-9442-65a71ba36ab6' of framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000 at executor(1)@10.3.1.5:58360
I0301 11:13:00.395835 7792 slave.cpp:922] Agent terminating
W0301 11:13:00.395835 7792 slave.cpp:3875] Ignoring shutdown framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000 because it is terminating
I0301 11:13:00.395835 3904 master.cpp:10357] Removing task c089b288-d808-4c8c-9442-65a71ba36ab6 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000 on agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 at slave(398)@10.3.1.5:58339 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 11:13:00.398835 1376 containerizer.cpp:2338] Destroying container 6250952d-c4ad-42e8-a115-0c87830b89eb in RUNNING state
I0301 11:13:00.398835 2876 hierarchical.cpp:344] Removed framework 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-0000
I0301 11:13:00.398835 1376 containerizer.cpp:2952] Transitioning the state of container 6250952d-c4ad-42e8-a115-0c87830b89eb from RUNNING to DESTROYING
I0301 11:13:00.398835 3904 master.cpp:1306] Agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 at slave(398)@10.3.1.5:58339 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0301 11:13:00.399962 3904 master.cpp:3276] Disconnecting agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 at slave(398)@10.3.1.5:58339 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 11:13:00.400837 3904 master.cpp:3295] Deactivating agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 at slave(398)@10.3.1.5:58339 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 11:13:00.400837 240 hierarchical.cpp:766] Agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0 deactivated
I0301 11:13:00.400837 1376 launcher.cpp:156] Asked to destroy container 6250952d-c4ad-42e8-a115-0c87830b89eb
I0301 11:13:00.416858 240 containerizer.cpp:2791] Container 6250952d-c4ad-42e8-a115-0c87830b89eb has exited
I0301 11:13:00.451861 9132 master.cpp:1149] Master terminating
I0301 11:13:00.453861 7972 hierarchical.cpp:609] Removed agent 1c9f8c1a-f5a9-4cd2-8de8-e0edd0b575e3-S0
I0301 11:13:00.844225 1524 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 1, 2018, 9:48 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65864/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 9:48 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-4549
> https://issues.apache.org/jira/browse/MESOS-4549
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `os::spawn`'s return type was changed from `int` to `Option<int>`, so
> the code in mesos was changed accordingly.
>
>
> Diffs
> -----
>
> src/linux/fs.cpp dae094224321c0974c705023daf076409049de51
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169
> src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
>
>
> Diff: https://reviews.apache.org/r/65864/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65864: Updated mesos code with the new `os::spawn`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65864/#review198445
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65839, 65861, 65862, 65840, 65841, 65863, 65842, 65864]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 1, 2018, 9:48 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65864/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 9:48 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-4549
> https://issues.apache.org/jira/browse/MESOS-4549
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `os::spawn`'s return type was changed from `int` to `Option<int>`, so
> the code in mesos was changed accordingly.
>
>
> Diffs
> -----
>
> src/linux/fs.cpp dae094224321c0974c705023daf076409049de51
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169
> src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
>
>
> Diff: https://reviews.apache.org/r/65864/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65864: Updated mesos code with the new `os::spawn`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65864/#review198737
-----------------------------------------------------------
Ship it!
- Andrew Schwartzmeyer
On March 1, 2018, 1:48 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65864/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 1:48 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-4549
> https://issues.apache.org/jira/browse/MESOS-4549
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `os::spawn`'s return type was changed from `int` to `Option<int>`, so
> the code in mesos was changed accordingly.
>
>
> Diffs
> -----
>
> src/linux/fs.cpp dae094224321c0974c705023daf076409049de51
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169
> src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e
>
>
> Diff: https://reviews.apache.org/r/65864/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>