You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2016/04/05 05:53:57 UTC
Review Request 45728: SENTRY-1176: Update thrift API for export with
specific auth object
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45728/
-----------------------------------------------------------
Review request for sentry.
Repository: sentry
Description
-------
Update thrift API for export with specific auth object
Diffs
-----
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java 8145252
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 40889e8
Diff: https://reviews.apache.org/r/45728/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 45728: SENTRY-1176: Update thrift API for export
with specific auth object
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45728/#review128054
-----------------------------------------------------------
Ship it!
Ship It!
- Colin Ma
On 四月 5, 2016, 6:28 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45728/
> -----------------------------------------------------------
>
> (Updated 四月 5, 2016, 6:28 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update thrift API for export with specific auth object
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java 8145252
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 40889e8
>
> Diff: https://reviews.apache.org/r/45728/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 45728: SENTRY-1176: Update thrift API for export
with specific auth object
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45728/#review128055
-----------------------------------------------------------
Ship it!
Ship It!
- Dapeng Sun
On 四月 5, 2016, 2:28 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45728/
> -----------------------------------------------------------
>
> (Updated 四月 5, 2016, 2:28 p.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update thrift API for export with specific auth object
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java 8145252
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 40889e8
>
> Diff: https://reviews.apache.org/r/45728/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 45728: SENTRY-1176: Update thrift API for export
with specific auth object
Posted by Jerry Chen <ha...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45728/#review127053
-----------------------------------------------------------
LGTM
- Jerry Chen
On April 5, 2016, 6:28 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45728/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 6:28 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update thrift API for export with specific auth object
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java 8145252
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 40889e8
>
> Diff: https://reviews.apache.org/r/45728/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 45728: SENTRY-1176: Update thrift API for export
with specific auth object
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45728/
-----------------------------------------------------------
(Updated April 5, 2016, 6:28 a.m.)
Review request for sentry.
Repository: sentry
Description
-------
Update thrift API for export with specific auth object
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java 8145252
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 40889e8
Diff: https://reviews.apache.org/r/45728/diff/
Testing
-------
Thanks,
Colin Ma
RE: Review Request 45728: SENTRY-1176: Update thrift API for export
with specific auth object
Posted by "Chen, Haifeng" <ha...@intel.com>.
Named filter is difficult to understand and the “named” has different implications.
If you want to support (either now or in the future) more flexible filtering such as wildcard, I suggest to use the name like objectFilter.
But if you don’t want to support wildcard and only allow one object path, use objectName or objectPath.
Thanks,
Haifeng
From: Colin Ma [mailto:noreply@reviews.apache.org] On Behalf Of Colin Ma
Sent: Tuesday, April 5, 2016 2:03 PM
To: Chen, Haifeng <ha...@intel.com>; Ma, Junjie <ju...@intel.com>; sentry <de...@sentry.incubator.apache.org>
Subject: Re: Review Request 45728: SENTRY-1176: Update thrift API for export with specific auth object
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45728/
On April 5th, 2016, 5:45 a.m. UTC, Jerry Chen wrote:
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift<https://reviews.apache.org/r/45728/diff/1/?file=1325581#file1325581line244> (Diff revision 1)
244
3: optional string authObjectFilter # filter for specific auth object
My oppinion authObjectFilter is not quite a good name here. Naming suggestions:
objectName
objectPath
how about named filter?
- Colin
On April 5th, 2016, 3:53 a.m. UTC, Colin Ma wrote:
Review request for sentry.
By Colin Ma.
Updated April 5, 2016, 3:53 a.m.
Repository: sentry
Description
Update thrift API for export with specific auth object
Diffs
* sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java (8145252)
* sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift (40889e8)
View Diff<https://reviews.apache.org/r/45728/diff/>
Re: Review Request 45728: SENTRY-1176: Update thrift API for export
with specific auth object
Posted by Colin Ma <ju...@intel.com>.
> On April 5, 2016, 5:45 a.m., Jerry Chen wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift, line 244
> > <https://reviews.apache.org/r/45728/diff/1/?file=1325581#file1325581line244>
> >
> > My oppinion authObjectFilter is not quite a good name here. Naming suggestions:
> > objectName
> > objectPath
how about named filter?
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45728/#review127038
-----------------------------------------------------------
On April 5, 2016, 3:53 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45728/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 3:53 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update thrift API for export with specific auth object
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java 8145252
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 40889e8
>
> Diff: https://reviews.apache.org/r/45728/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 45728: SENTRY-1176: Update thrift API for export
with specific auth object
Posted by Jerry Chen <ha...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45728/#review127038
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift (line 244)
<https://reviews.apache.org/r/45728/#comment190170>
My oppinion authObjectFilter is not quite a good name here. Naming suggestions:
objectName
objectPath
- Jerry Chen
On April 5, 2016, 3:53 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45728/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 3:53 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update thrift API for export with specific auth object
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java 8145252
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 40889e8
>
> Diff: https://reviews.apache.org/r/45728/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>