You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2013/12/15 19:10:14 UTC

Re: Review Request 14220: OOZIE-1548: OozieDBCLI changes to convert clob to blob and remove the discriminator column

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14220/
-----------------------------------------------------------

(Updated Dec. 15, 2013, 6:10 p.m.)


Review request for oozie.


Changes
-------

Mapping tool set to create indexes for tables already mapped once
Addressed comments
E2E upgrade tested from oozie 3.3 in mysql


Bugs: OOZIE-1548
    https://issues.apache.org/jira/browse/OOZIE-1548


Repository: oozie


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1548


Diffs (updated)
-----

  trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1550993 
  trunk/tools/src/test/java/org/apache/oozie/tools/TestOozieDBCLI.java 1550993 

Diff: https://reviews.apache.org/r/14220/diff/


Testing
-------

E2E-Tested upgrade from 4.0 on derby, postgres, mysql, oracle
E2E-Tested upgrade from 3.3 on derby.


Thanks,

Virag Kothari

Re: Review Request 14220: OOZIE-1548: OozieDBCLI changes to convert clob to blob and remove the discriminator column

Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14220/#review30840
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Abdelnur


On Dec. 15, 2013, 6:10 p.m., Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14220/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 6:10 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1548
>     https://issues.apache.org/jira/browse/OOZIE-1548
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1548
> 
> 
> Diffs
> -----
> 
>   trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1550993 
>   trunk/tools/src/test/java/org/apache/oozie/tools/TestOozieDBCLI.java 1550993 
> 
> Diff: https://reviews.apache.org/r/14220/diff/
> 
> 
> Testing
> -------
> 
> E2E-Tested upgrade from 4.0 on derby, postgres, mysql, oracle
> E2E-Tested upgrade from 3.3 on derby.
> 
> 
> Thanks,
> 
> Virag Kothari
> 
>

Re: Review Request 14220: OOZIE-1548: OozieDBCLI changes to convert clob to blob and remove the discriminator column

Posted by Virag Kothari <vi...@yahoo-inc.com>.

> On Dec. 17, 2013, 9:05 p.m., Robert Kanter wrote:
> > LGTM; though it might be good for Mona or Ryota to take another look too.
> > 
> > One question: you took out the MySQL MEDIUMTEXT stuff because it will use MEDIUMTEXT when you upgrade from the Oozie 4 DB to Oozie 5 DB regardless of whether or not it was MEDIUMTEXT or TEXT, right?
> 
> Robert Kanter wrote:
>     (and from Oozie 3 DB to Oozie 5 DB)?

Yup, it will convert to mediumblob regardless of whether or not it was MEDIUMTEXT OR TEXT


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14220/#review30566
-----------------------------------------------------------


On Dec. 15, 2013, 6:10 p.m., Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14220/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 6:10 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1548
>     https://issues.apache.org/jira/browse/OOZIE-1548
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1548
> 
> 
> Diffs
> -----
> 
>   trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1550993 
>   trunk/tools/src/test/java/org/apache/oozie/tools/TestOozieDBCLI.java 1550993 
> 
> Diff: https://reviews.apache.org/r/14220/diff/
> 
> 
> Testing
> -------
> 
> E2E-Tested upgrade from 4.0 on derby, postgres, mysql, oracle
> E2E-Tested upgrade from 3.3 on derby.
> 
> 
> Thanks,
> 
> Virag Kothari
> 
>

Re: Review Request 14220: OOZIE-1548: OozieDBCLI changes to convert clob to blob and remove the discriminator column

Posted by Robert Kanter <rk...@cloudera.com>.

> On Dec. 17, 2013, 9:05 p.m., Robert Kanter wrote:
> > LGTM; though it might be good for Mona or Ryota to take another look too.
> > 
> > One question: you took out the MySQL MEDIUMTEXT stuff because it will use MEDIUMTEXT when you upgrade from the Oozie 4 DB to Oozie 5 DB regardless of whether or not it was MEDIUMTEXT or TEXT, right?

(and from Oozie 3 DB to Oozie 5 DB)?


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14220/#review30566
-----------------------------------------------------------


On Dec. 15, 2013, 6:10 p.m., Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14220/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 6:10 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1548
>     https://issues.apache.org/jira/browse/OOZIE-1548
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1548
> 
> 
> Diffs
> -----
> 
>   trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1550993 
>   trunk/tools/src/test/java/org/apache/oozie/tools/TestOozieDBCLI.java 1550993 
> 
> Diff: https://reviews.apache.org/r/14220/diff/
> 
> 
> Testing
> -------
> 
> E2E-Tested upgrade from 4.0 on derby, postgres, mysql, oracle
> E2E-Tested upgrade from 3.3 on derby.
> 
> 
> Thanks,
> 
> Virag Kothari
> 
>

Re: Review Request 14220: OOZIE-1548: OozieDBCLI changes to convert clob to blob and remove the discriminator column

Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14220/#review30566
-----------------------------------------------------------

Ship it!


LGTM; though it might be good for Mona or Ryota to take another look too.

One question: you took out the MySQL MEDIUMTEXT stuff because it will use MEDIUMTEXT when you upgrade from the Oozie 4 DB to Oozie 5 DB regardless of whether or not it was MEDIUMTEXT or TEXT, right?

- Robert Kanter


On Dec. 15, 2013, 6:10 p.m., Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14220/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 6:10 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1548
>     https://issues.apache.org/jira/browse/OOZIE-1548
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1548
> 
> 
> Diffs
> -----
> 
>   trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1550993 
>   trunk/tools/src/test/java/org/apache/oozie/tools/TestOozieDBCLI.java 1550993 
> 
> Diff: https://reviews.apache.org/r/14220/diff/
> 
> 
> Testing
> -------
> 
> E2E-Tested upgrade from 4.0 on derby, postgres, mysql, oracle
> E2E-Tested upgrade from 3.3 on derby.
> 
> 
> Thanks,
> 
> Virag Kothari
> 
>