You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/06/04 13:39:51 UTC
Review Request: Automation: Memory limits tests from Resource Limits Tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Description
-------
Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
Diffs
-----
test/integration/component/test_memory_limits.py PRE-CREATION
Diff: https://reviews.apache.org/r/11626/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On June 17, 2013, 10:32 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_memory_limits.py, line 184
> > <https://reviews.apache.org/r/11626/diff/1/?file=300447#file300447line184>
> >
> > what if networks is an empty list? []
Removed this method as it is no longer used anywhere.
> On June 17, 2013, 10:32 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_memory_limits.py, line 172
> > <https://reviews.apache.org/r/11626/diff/1/?file=300447#file300447line172>
> >
> > Same here, anyone reading the test should be able to make sense of Network.list followed by assert faster than having to hunt down what get_network does each time.
Removed the method.
> On June 17, 2013, 10:32 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_memory_limits.py, line 145
> > <https://reviews.apache.org/r/11626/diff/1/?file=300447#file300447line145>
> >
> > Do we need this method? I think keeping the VM creation step (VirtualMachine.create, asserts1, assert2) is easier than refactoring this into a test specific method for each test suite.
This has been factored into different function for readability purpose. The test cases become too lengthy if we put inline statements instead of function call, compelling the reader scroll up and down to read one test case.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review21967
-----------------------------------------------------------
On Aug. 9, 2013, 1:21 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 1:21 p.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 695edf7
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request: Automation: Memory limits tests from Resource Limits
Tests
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review21967
-----------------------------------------------------------
Gaurav, I think this diff suffers from the same problems as the previous diff for memory limit tests. The patch is incomplete as it doesn't include changes to the library for memory limit objects - Resources, get_resouce_type etc.
1. Please split each class into a different module. This allows them to be processed in parallel as they have no dependency between each other. VPC related suites suffer the same problem. It takes over 3 hrs to run them because we've put too many tests into the same suite
2. You can organize the tests into test/integration/component/memory_limits/test_domain_limits.py|test_project_limits.py etc. The test discoverer will drill down to find the tests to be run
3. There are a lot of repeated use of small methods like checkUpdateResourceCount, createInstance etc. This is good for refactoring but it makes it harder for someone reading the test to quickly understand what each method is doing. Instead looking at VM.create, ResourceCount.update will make it easier to look in one place - the libraries.
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45284>
The entity 'Resource' needs to be added to integration.lib.base
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45285>
get_resource_type is missing in utils
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45286>
remove the `pass` here
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45288>
Do we need this method? I think keeping the VM creation step (VirtualMachine.create, asserts1, assert2) is easier than refactoring this into a test specific method for each test suite.
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45287>
account reference is account.account
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45289>
Same here, anyone reading the test should be able to make sense of Network.list followed by assert faster than having to hunt down what get_network does each time.
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45290>
what if networks is an empty list? []
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45291>
account dereferences as account.name only.
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45292>
account dereferences as account.name only.
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45293>
This calls listHosts and not findHostSuitableForMigration I think?
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45295>
Does it make sense to break this test down into smaller steps?
class Test_LimitsInVmLifeCycle():
test_migrate_limitcheck
test_stop_limitcheck
test_reboot_limitcheck
Putting in so many life cycle operations into the same test is complicating it.
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45294>
When you use an rtype can you also add a comment?
checkUpdatedResourceCount(account, rtype=9)#RAM
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45296>
Reuse service offerings?
test/integration/component/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment45297>
I'm confused - are we checking the RAM usage or are we updating the resource count for memory usage? The comment in the test confuses me.
- Prasanna Santhanam
On June 4, 2013, 11:39 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:39 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/test_memory_limits.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request: Automation: Memory limits tests from Resource Limits
Tests
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review21973
-----------------------------------------------------------
If a lot of tests are generatable from the same class, we should explore using something like DDT
http://ddt.readthedocs.org/en/latest/example.html
Do you think it's possible?
- Prasanna Santhanam
On June 4, 2013, 11:39 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:39 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/test_memory_limits.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request: Automation: Memory limits tests from Resource Limits
Tests
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review21970
-----------------------------------------------------------
I've reviewed the first two suites of this large module but the others suffer the same issues. Please fix them and upload a new patch.
Thanks
- Prasanna Santhanam
On June 4, 2013, 11:39 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:39 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/test_memory_limits.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Aug. 1, 2013, 4:57 p.m., Sanjay Tripathi wrote:
> > test/integration/component/memory_limits/test_domain_limits.py, line 302
> > <https://reviews.apache.org/r/11626/diff/2/?file=328254#file328254line302>
> >
> > Migration of a VM to another host will not affect/update any count because VM still belongs to the same account; instead of doing migration test, you should test assignVM to other account in which VM get assigned to other account and affects/updates the count for both the accounts.
Will add separate test for assigning vm. This test case is targeted at migrate scenario.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review24360
-----------------------------------------------------------
On Aug. 9, 2013, 1:21 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 1:21 p.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 695edf7
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Sanjay Tripathi <sa...@citrix.com>.
> On Aug. 1, 2013, 11:27 a.m., Sanjay Tripathi wrote:
> > test/integration/component/memory_limits/test_domain_limits.py, line 429
> > <https://reviews.apache.org/r/11626/diff/2/?file=328254#file328254line429>
> >
> > use listAccounts and assert to verify count.
Also, can you close the issues opened in this request once you resolve them.
- Sanjay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review24360
-----------------------------------------------------------
On July 27, 2013, 1:21 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 1:21 p.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 8d9a25d
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review24360
-----------------------------------------------------------
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48217>
"domain" object is same as parent "domain" object, should use a different name.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48352>
Use the listResourceLimit API to get the limit set for account. If you fetch the limit from the configuration, you will not get the limit set by using updateResourceLimit API.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48353>
use listAccounts to get the resource count, also use assert to verify the count with the expected count.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48354>
again, use listAccounts and assert
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48355>
use listAccounts and assert.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48356>
Migration of a VM to another host will not affect/update any count because VM still belongs to the same account; instead of doing migration test, you should test assignVM to other account in which VM get assigned to other account and affects/updates the count for both the accounts.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48357>
Use listAccounts to get the count.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48358>
again, use listResourceLimits to get the limit set for this account.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48359>
"Update" should be "List"
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48360>
I doubt if this test runs successfully because you are reaching the limit after the deployment of 1st VM itself.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48361>
use listAccounts and assert to verify count.
- Sanjay Tripathi
On July 27, 2013, 1:21 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 1:21 p.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 8d9a25d
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by sailaja mada <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review26076
-----------------------------------------------------------
Ship it!
Ship It!
- sailaja mada
On Sept. 12, 2013, 10:19 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 10:19 a.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by sailaja mada <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review26136
-----------------------------------------------------------
Ship it!
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=f9467470
- sailaja mada
On Sept. 12, 2013, 10:19 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 10:19 a.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/
-----------------------------------------------------------
(Updated Sept. 12, 2013, 3:49 p.m.)
Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
Changes
-------
Removed trailing white-spaces.
Repository: cloudstack-git
Description
-------
Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
Diffs (updated)
-----
test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
Diff: https://reviews.apache.org/r/11626/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/
-----------------------------------------------------------
(Updated Sept. 12, 2013, 2:53 p.m.)
Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
Changes
-------
This patch also suffered from indentation issues like CPU limits patch. I have fixed the issues.
Please commit this if this is good to go. Sanjay has given go ahead.
Repository: cloudstack-git
Description
-------
Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
Diffs (updated)
-----
test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
Diff: https://reviews.apache.org/r/11626/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review25788
-----------------------------------------------------------
Ship it!
Looks good to me.
- Sanjay Tripathi
On Aug. 29, 2013, 10:54 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2013, 10:54 a.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/
-----------------------------------------------------------
(Updated Aug. 29, 2013, 4:24 p.m.)
Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
Changes
-------
Updated patch. Eliminated base.py and common.py changes from this patch as they are already committed through CPU limits patch.
Repository: cloudstack-git
Description
-------
Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
Diffs (updated)
-----
test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
Diff: https://reviews.apache.org/r/11626/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review25723
-----------------------------------------------------------
Diff for common.py is not available in the patch, update the patch against latest code.
- Sanjay Tripathi
On Aug. 29, 2013, 7:32 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2013, 7:32 a.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 695edf7
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/
-----------------------------------------------------------
(Updated Aug. 29, 2013, 1:02 p.m.)
Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
Changes
-------
Review changes.
Removed duplicate test cases and added configuration test cases (Similar to those for CPU) which were missing in test_memory_limits.
Repository: cloudstack-git
Description
-------
Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
Diffs (updated)
-----
test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 695edf7
tools/marvin/marvin/integration/lib/common.py 4f5acef
Diff: https://reviews.apache.org/r/11626/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review25546
-----------------------------------------------------------
Can you please remove the trailing white spaces from the patch so that it applies cleanly.
- Sanjay Tripathi
On Aug. 9, 2013, 7:51 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 7:51 a.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 695edf7
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review25218
-----------------------------------------------------------
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment49994>
This is not required as changeServiceOffering should update the resource count.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment49995>
same reason, please remove this update call.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment49996>
Please change the "update resource count" to "list resource count" as we are list the resource count in the test.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment49997>
same reason, please change the description accordingly.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment49998>
please change the description accordingly.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment50000>
api_client should point to cdamin_2.
test/integration/component/memory_limits/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment50004>
please change the test name as per the test description and implementation.
Also change the description of the test accordingly.
test/integration/component/memory_limits/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment50005>
This update call is not required.
test/integration/component/memory_limits/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment50006>
This update call is not required.
test/integration/component/memory_limits/test_memory_limits.py
<https://reviews.apache.org/r/11626/#comment50007>
change the description of test according to the test implementation.
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/11626/#comment50009>
remove the resource type 12 and 13 as they are not yet implemented.
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/11626/#comment50010>
please remove the resource type 12 and 13.
- Sanjay Tripathi
On Aug. 9, 2013, 7:51 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 7:51 a.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 695edf7
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/
-----------------------------------------------------------
(Updated Aug. 9, 2013, 7:51 a.m.)
Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
Changes
-------
Automation: Limit Resources: Memory Limits - changes as per review
Repository: cloudstack-git
Description
-------
Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
Diffs (updated)
-----
test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 695edf7
tools/marvin/marvin/integration/lib/common.py 4f5acef
Diff: https://reviews.apache.org/r/11626/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/
-----------------------------------------------------------
(Updated July 27, 2013, 1:21 p.m.)
Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
Changes
-------
including dev and QA for review
Repository: cloudstack-git
Description
-------
Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
Diffs
-----
test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 8d9a25d
tools/marvin/marvin/integration/lib/common.py 4f5acef
Diff: https://reviews.apache.org/r/11626/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review23945
-----------------------------------------------------------
Review 11626 PASSED the build test
The url of build cloudstack-master-with-patch #47 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/47/
- Jenkins Cloudstack.org
On July 26, 2013, 11:27 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 11:27 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 8d9a25d
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/
-----------------------------------------------------------
(Updated July 26, 2013, 11:27 a.m.)
Review request for cloudstack and Prasanna Santhanam.
Changes
-------
Incorporated the review changes
Repository: cloudstack-git
Description
-------
Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
Diffs (updated)
-----
test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 8d9a25d
tools/marvin/marvin/integration/lib/common.py 4f5acef
Diff: https://reviews.apache.org/r/11626/diff/
Testing
-------
Thanks,
Gaurav Aradhye