You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/08 07:24:35 UTC
[GitHub] [dolphinscheduler] baisui1981 opened a new issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
baisui1981 opened a new issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
as you konw , a new task node 'PIGEON' has been add in the taskbar in DS release version:2.0, the task node `PIGEON` is dedicated to wrapped the [TIS](http://tis.pub/) which is focuse on agile data movement .
Originally, I wanted to name the new task node TIS，but at then the open source protocol of tis is AGLP by TIS used，it is inconsistent with Apache2 protocol, as a result ，the name of new task node can only use a strange name with “PIGEON”.
Fortunately，TIS has changed open source protocol to [Apache2](https://github.com/qlangtech/tis/blob/master/LICENSE),so I wanted to restore the name to TIS
thanks a lot
### Use case
_No response_
### Related issues
https://github.com/apache/dolphinscheduler/issues/5992
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265#issuecomment-1013780114
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265#issuecomment-1007834577
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265#issuecomment-988616926
hi @baisui1981 , I think the `PIGEON` is a universal websocket way for DS, and TIS is one of the remote servers.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] baisui1981 edited a comment on issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
Posted by GitBox <gi...@apache.org>.
baisui1981 edited a comment on issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265#issuecomment-988897555
> hi @baisui1981 , I think the `PIGEON` is a universal websocket way for DS, and TIS is one of the remote servers. So they are not the same thing. What do you think?
Thanks for your reply.Actually, I am the core developer of `PIGEON` node, When the initial PR was submitted, the node name was indeed called TIS, but it was changed to `PIGEON` because of the open source protocol of TIS is inconsist with apache2.
you can review the code [PigeonTask.java](https://github.com/apache/dolphinscheduler/blob/11844415b0d71711ecc0942c0f55651b7db6fd83/dolphinscheduler-task-plugin/dolphinscheduler-task-pigeon/src/main/java/org/apache/dolphinscheduler/plugin/task/pigeon/PigeonTask.java#L77)
,there are 3 steps to cooperate with outter system like TIS：
- trigger a new job which is predefined in TIS.
- poll the executing task status which is running in TIS. Quit once find status is success or failure.
- collect the job executing log by WebSocket（WebSocket is just one part of PIGEON）
All interface parameters interacting with TIS are deeply coupled with TIS. To be honest, it is difficult for PIGEON to have other application scenarios except docking with TIS, so I think it is appropriate to replace the name of PIGEON with TIS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265#issuecomment-1007834577
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng edited a comment on issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
Posted by GitBox <gi...@apache.org>.
caishunfeng edited a comment on issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265#issuecomment-988616926
hi @baisui1981 , I think the `PIGEON` is a universal websocket way for DS, and TIS is one of the remote servers.
So they are not the same thing. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265#issuecomment-988563539
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] baisui1981 commented on issue #7265: [Feature][task] rename task node 'PIGEON' to 'TIS'
Posted by GitBox <gi...@apache.org>.
baisui1981 commented on issue #7265:
URL: https://github.com/apache/dolphinscheduler/issues/7265#issuecomment-988897555
> hi @baisui1981 , I think the `PIGEON` is a universal websocket way for DS, and TIS is one of the remote servers. So they are not the same thing. What do you think?
Thanks for your reply.Actually, I am the core developer of `PIGEON` node, When the initial PR was submitted, the node name was indeed called tis, but it was changed to `PIGEON` because of the open source protocol of TIS is inconsist with apache2.
you can review the code [PigeonTask.java](https://github.com/apache/dolphinscheduler/blob/11844415b0d71711ecc0942c0f55651b7db6fd83/dolphinscheduler-task-plugin/dolphinscheduler-task-pigeon/src/main/java/org/apache/dolphinscheduler/plugin/task/pigeon/PigeonTask.java#L77)
,there are 3 steps to cooperate with outter system like TIS：
- trigger a new job which is predefined in TIS.
- poll the executing task status which is running in TIS. Quit once find status is success or failure.
- collect the job executing log by WebSocket（WebSocket is just one part of PIGEON）
All interface parameters interacting with TIS are deeply coupled with TIS. To be honest, it is difficult for PIGEON to have other application scenarios except docking with TIS, so I think it is appropriate to replace the name of PIGEON with TIS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org