You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flume.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/07 15:39:00 UTC
[jira] [Commented] (FLUME-3280) Improve maven build to help code
reviews by adding static code analyzer to it
[ https://issues.apache.org/jira/browse/FLUME-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678402#comment-16678402 ]
ASF GitHub Bot commented on FLUME-3280:
---------------------------------------
GitHub user szaboferee opened a pull request:
https://github.com/apache/flume/pull/232
FLUME-3280 Improve maven build to help code reviews by adding static …
…code analyzer
Adding spotbugs, pmd to the build.
moving flume-checkstyle to a new build-support module that contains
any future build tool configuration.
Fixed some trivial checkstyle issues.
Updated apache parent version and maven plugin versions.
Added maxAllowedViolations so this commit could contain only the new checks
and not any code change.
Did some cleanup in the pom files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/szaboferee/flume build_support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flume/pull/232.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #232
----
commit 1b897c8c13f405bf57f13e3e341b818fc389cb66
Author: Ferenc Szabó <fs...@...>
Date: 2018-11-06T16:32:40Z
FLUME-3280 Improve maven build to help code reviews by adding static code analyzer
Adding spotbugs, pmd to the build.
moving flume-checkstyle to a new build-support module that contains
any future build tool configuration.
Fixed some trivial checkstyle issues.
Updated apache parent version and maven plugin versions.
Added maxAllowedViolations so this commit could contain only the new checks
and not any code change.
Did some cleanup in the pom files.
----
> Improve maven build to help code reviews by adding static code analyzer to it
> -----------------------------------------------------------------------------
>
> Key: FLUME-3280
> URL: https://issues.apache.org/jira/browse/FLUME-3280
> Project: Flume
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Ferenc Szabo
> Assignee: Ferenc Szabo
> Priority: Major
> Fix For: 1.9.0
>
>
> Also do a pom clean up and update maven plugin versions where possible
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@flume.apache.org
For additional commands, e-mail: issues-help@flume.apache.org