[jira] [Commented] (COUCHDB-1805) Grouping on reduce views tests for equality rather than ICU equivalence

["Adam Kocoloski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603843#comment-14603843 ] 

Adam Kocoloski commented on COUCHDB-1805:
-----------------------------------------

Going through some of my old bug reports ... this one is still latent, but is the fix to simply remove the group_rows_fun altogether and use the group_level directly? If we do that we should hit the couch_btree code that constructs the appropriate grouping functions using the sort function defined on the tree:

https://github.com/apache/couchdb-couch/blob/a99f39/src/couch_btree.erl#L106-L160

> Grouping on reduce views tests for equality rather than ICU equivalence
> -----------------------------------------------------------------------
>
>                 Key: COUCHDB-1805
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1805
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Adam Kocoloski
>
> If I emit keys from two documents that are distinct but compare equal from ICU's point of view, a group=true query over the view will show two distinct rows.  I think the expected behavior is that the rows are combined when ICU collation says the keys compare equal.
> I think part of the fix is to modify the group_rows_fun to call out to ICU instead of doing a simple == comparison:
> https://github.com/apache/couchdb/blob/48dc96/src/couch_mrview/src/couch_mrview.erl#L354-L363



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)