You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/09 22:19:11 UTC
[GitHub] [airflow] XD-DENG opened a new pull request #12216: Simplify string expressions & Use f-string
XD-DENG opened a new pull request #12216:
URL: https://github.com/apache/airflow/pull/12216
This is a follow-up clean-up work for the minor string issues caused in the process of introducing Black.
Similar to what @kaxil has done in https://github.com/apache/airflow/pull/12123
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12216: Simplify string expressions & Use f-string
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12216:
URL: https://github.com/apache/airflow/pull/12216#discussion_r520305079
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -2801,9 +2801,7 @@ def _split_tablename(
) -> Tuple[str, str, str]:
if '.' not in table_input:
- raise ValueError(
- 'Expected target table name in the format of ' '<dataset>.<table>. Got: {}'.format(table_input)
- )
+ raise ValueError(f'Expected table name in the format of <dataset>.<table>. Got: {table_input}')
Review comment:
Fix the earlier static check error.
Please note that I made a minor change to the content here (remove word "`target`"), for two reasons:
- otherwise the updated line will be longer than 110
- more importantly, this `_split_tablename()` method is used for both `source` and `destination`. Word `target` may be a bit misleading (sounds only for `destination`), and the updated one is meaning enough to me as well.
CC @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12216: Simplify string expressions & Use f-string
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12216:
URL: https://github.com/apache/airflow/pull/12216#issuecomment-724313075
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #12216: Simplify string expressions & Use f-string
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #12216:
URL: https://github.com/apache/airflow/pull/12216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12216: Simplify string expressions & Use f-string
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12216:
URL: https://github.com/apache/airflow/pull/12216#discussion_r520305079
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -2801,9 +2801,7 @@ def _split_tablename(
) -> Tuple[str, str, str]:
if '.' not in table_input:
- raise ValueError(
- 'Expected target table name in the format of ' '<dataset>.<table>. Got: {}'.format(table_input)
- )
+ raise ValueError(f'Expected table name in the format of <dataset>.<table>. Got: {table_input}')
Review comment:
Fix the earlier static check error.
Please note that I made a minor change to the content here for two reasons:
- otherwise the updated line will be longer than 110
- more importantly, this `_split_tablename` method is used for both `source` and `destination`. Word `target` may be a bit misleading, and the updated one is meaning enough to me as well.
CC @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12216: Simplify string expressions & Use f-string
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12216:
URL: https://github.com/apache/airflow/pull/12216#issuecomment-724385664
Static checks are sad. Can you fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12216: Simplify string expressions & Use f-string
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12216:
URL: https://github.com/apache/airflow/pull/12216#issuecomment-724321261
[The Workflow run](https://github.com/apache/airflow/actions/runs/354847559) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org