You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/13 04:37:29 UTC
[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao opened a new pull request #385: [YUNIKORN-1103]Support fetching queue name from pod annotation yunikorn.apache.org/queue
HuangTing-Yao opened a new pull request #385:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/385
### What is this PR for?
we can only get queue name from pod label before, now we can also get queue name from pod annotation.
### What type of PR is it?
* [ ] - Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1103
### How should this be tested?
UT test
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #385: [YUNIKORN-1103]Support fetching queue name from pod annotation yunikorn.apache.org/queue
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/385#issuecomment-1068728347
@HuangTing-Yao pls create a JIRA to track the doc changes.
For the SI side, I think I am going to create another JIRA to move constants to SI, to avoid dup code. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #385: [YUNIKORN-1103]Support fetching queue name from pod annotation yunikorn.apache.org/queue
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/385#issuecomment-1066025924
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e2b585) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/5d89c9c9a12c3ec90ddd85541cdb9ce2060ea4a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d89c9c) will **increase** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 64.89% 65.00% +0.10%
==========================================
Files 41 41
Lines 6267 6269 +2
==========================================
+ Hits 4067 4075 +8
+ Misses 2044 2038 -6
Partials 156 156
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `57.34% <100.00%> (+4.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5d89c9c...9e2b585](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao commented on pull request #385: [YUNIKORN-1103]Support fetching queue name from pod annotation yunikorn.apache.org/queue
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on pull request #385:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/385#issuecomment-1069077903
> LGTM. Please also create a JIRA for the website change to explain that label-based queue name takes precedence over the annotation-based one
Hi @yuchaoran2011 , I think we can explain it in [Yunikorn-596](https://issues.apache.org/jira/browse/YUNIKORN-596)
In Yunikorn-596, we can have a independence page to introduce all the labels and annotations in Yunikorn, and also explain label-based and annotation-based queue name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #385: [YUNIKORN-1103]Support fetching queue name from pod annotation yunikorn.apache.org/queue
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #385:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org