You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/11/04 21:17:49 UTC

[Impala-ASF-CR] IMPALA-11004 (part 2): Upgrade glog library for Impala

Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17951


Change subject: IMPALA-11004 (part 2): Upgrade glog library for Impala
......................................................................

IMPALA-11004 (part 2): Upgrade glog library for Impala

This patch bump up version of third-party library glog to 0.3.5.

Testing:
 - Passed core DEBUG build and exhaustive DEBUG build.
 - Passed core ASAN build.

Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17951/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
Gerrit-Change-Number: 17951
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11004 (part 2): Upgrade glog library for Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17951 )

Change subject: IMPALA-11004 (part 2): Upgrade glog library for Impala
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9721/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
Gerrit-Change-Number: 17951
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Nov 2021 21:39:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11004 (part 2): Upgrade glog library for Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17951 )

Change subject: IMPALA-11004 (part 2): Upgrade glog library for Impala
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7622/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
Gerrit-Change-Number: 17951
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 08:35:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11004 (part 2): Upgrade glog library for Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17951 )

Change subject: IMPALA-11004 (part 2): Upgrade glog library for Impala
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
Gerrit-Change-Number: 17951
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 14:46:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11004 (part 2): Upgrade glog library for Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17951 )

Change subject: IMPALA-11004 (part 2): Upgrade glog library for Impala
......................................................................


Patch Set 3:

https://jenkins.impala.io/job/gerrit-verify-dryrun/7621 was restarted due to Jenkins maintenance. Sorry for the inconvenience.


-- 
To view, visit http://gerrit.cloudera.org:8080/17951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
Gerrit-Change-Number: 17951
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 08:37:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11004 (part 2): Upgrade glog library for Impala

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17951 )

Change subject: IMPALA-11004 (part 2): Upgrade glog library for Impala
......................................................................

IMPALA-11004 (part 2): Upgrade glog library for Impala

This patch bump up version of third-party library glog to 0.3.5.

Testing:
 - Passed core DEBUG build and exhaustive DEBUG build.
 - Passed core ASAN build.

Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
Reviewed-on: http://gerrit.cloudera.org:8080/17951
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
Gerrit-Change-Number: 17951
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11004 (part 2): Upgrade glog library for Impala

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17951 )

Change subject: IMPALA-11004 (part 2): Upgrade glog library for Impala
......................................................................


Patch Set 3: Code-Review+2

This is looking good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/17951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
Gerrit-Change-Number: 17951
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Nov 2021 20:34:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11004 (part 2): Upgrade glog library for Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17951 )

Change subject: IMPALA-11004 (part 2): Upgrade glog library for Impala
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7621/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57ebb2f75f5bdb223d6e3f6b4de4f2ebaac68de
Gerrit-Change-Number: 17951
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 07:15:50 +0000
Gerrit-HasComments: No