You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/12/31 08:43:03 UTC
Review Request 41827: Sqoop2: Sqoop shell is accepting non existing
arguments
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41827/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2763
https://issues.apache.org/jira/browse/SQOOP-2763
Repository: sqoop-sqoop2
Description
-------
We happily accept non-existing arguments in the shell which is highly deceptive:
sqoop:000> set server --name x
Server is set successfully
sqoop:000>
or
sqoop:000> show connector --please
...
sqoop:000>
We should throw an exception or something if one is using incorrect/non-existing arguments.
Diffs
-----
common/pom.xml 078a785
common/src/main/java/org/apache/sqoop/cli/SqoopGnuParser.java PRE-CREATION
shell/pom.xml 1949a8e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 0845d8e
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java 97b6e3b
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
Diff: https://reviews.apache.org/r/41827/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 41827: Sqoop2: Sqoop shell is accepting non
existing arguments
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41827/#review112853
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Jan. 5, 2016, 2:54 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41827/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 2:54 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2763
> https://issues.apache.org/jira/browse/SQOOP-2763
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> We happily accept non-existing arguments in the shell which is highly deceptive:
> sqoop:000> set server --name x
> Server is set successfully
> sqoop:000>
> or
> sqoop:000> show connector --please
> ...
> sqoop:000>
> We should throw an exception or something if one is using incorrect/non-existing arguments.
>
>
> Diffs
> -----
>
> common/pom.xml 078a785
> common/src/main/java/org/apache/sqoop/cli/SqoopGnuParser.java PRE-CREATION
> shell/pom.xml 1949a8e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 0845d8e
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java 97b6e3b
> shell/src/test/java/org/apache/sqoop/shell/TestCloneCommand.java 53303af
> shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 1f559b6
> shell/src/test/java/org/apache/sqoop/shell/TestDeleteCommand.java 4165bf0
> shell/src/test/java/org/apache/sqoop/shell/TestDisableCommand.java a236685
> shell/src/test/java/org/apache/sqoop/shell/TestEnableCommand.java 6ce78eb
> shell/src/test/java/org/apache/sqoop/shell/TestGrantCommand.java 9f7f5b8
> shell/src/test/java/org/apache/sqoop/shell/TestRevokeCommand.java 88f04f2
> shell/src/test/java/org/apache/sqoop/shell/TestSetCommand.java b231cf2
> shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 6463bd5
> shell/src/test/java/org/apache/sqoop/shell/TestStartCommand.java b55b087
> shell/src/test/java/org/apache/sqoop/shell/TestStatusCommand.java 9fac463
> shell/src/test/java/org/apache/sqoop/shell/TestStopCommand.java e2bc6b8
> shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java f5062da
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
>
> Diff: https://reviews.apache.org/r/41827/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 41827: Sqoop2: Sqoop shell is accepting non
existing arguments
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41827/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 2:54 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2763
https://issues.apache.org/jira/browse/SQOOP-2763
Repository: sqoop-sqoop2
Description
-------
We happily accept non-existing arguments in the shell which is highly deceptive:
sqoop:000> set server --name x
Server is set successfully
sqoop:000>
or
sqoop:000> show connector --please
...
sqoop:000>
We should throw an exception or something if one is using incorrect/non-existing arguments.
Diffs (updated)
-----
common/pom.xml 078a785
common/src/main/java/org/apache/sqoop/cli/SqoopGnuParser.java PRE-CREATION
shell/pom.xml 1949a8e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 0845d8e
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java 97b6e3b
shell/src/test/java/org/apache/sqoop/shell/TestCloneCommand.java 53303af
shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 1f559b6
shell/src/test/java/org/apache/sqoop/shell/TestDeleteCommand.java 4165bf0
shell/src/test/java/org/apache/sqoop/shell/TestDisableCommand.java a236685
shell/src/test/java/org/apache/sqoop/shell/TestEnableCommand.java 6ce78eb
shell/src/test/java/org/apache/sqoop/shell/TestGrantCommand.java 9f7f5b8
shell/src/test/java/org/apache/sqoop/shell/TestRevokeCommand.java 88f04f2
shell/src/test/java/org/apache/sqoop/shell/TestSetCommand.java b231cf2
shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 6463bd5
shell/src/test/java/org/apache/sqoop/shell/TestStartCommand.java b55b087
shell/src/test/java/org/apache/sqoop/shell/TestStatusCommand.java 9fac463
shell/src/test/java/org/apache/sqoop/shell/TestStopCommand.java e2bc6b8
shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java f5062da
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
Diff: https://reviews.apache.org/r/41827/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 41827: Sqoop2: Sqoop shell is accepting non
existing arguments
Posted by Dian Fu <di...@gmail.com>.
> On Jan. 5, 2016, 2:39 a.m., Jarek Cecho wrote:
> > shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java, line 432
> > <https://reviews.apache.org/r/41827/diff/2/?file=1181399#file1181399line432>
> >
> > I'm wondering why this change from PRINCIPAL to PRIVILEGE?
Constants.FN_PRINCIPAL is a mistake, it should be Constants.FN_PRIVILEGE. This method tests function show privilege.
- Dian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41827/#review112744
-----------------------------------------------------------
On Jan. 5, 2016, 2:54 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41827/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 2:54 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2763
> https://issues.apache.org/jira/browse/SQOOP-2763
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> We happily accept non-existing arguments in the shell which is highly deceptive:
> sqoop:000> set server --name x
> Server is set successfully
> sqoop:000>
> or
> sqoop:000> show connector --please
> ...
> sqoop:000>
> We should throw an exception or something if one is using incorrect/non-existing arguments.
>
>
> Diffs
> -----
>
> common/pom.xml 078a785
> common/src/main/java/org/apache/sqoop/cli/SqoopGnuParser.java PRE-CREATION
> shell/pom.xml 1949a8e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 0845d8e
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java 97b6e3b
> shell/src/test/java/org/apache/sqoop/shell/TestCloneCommand.java 53303af
> shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 1f559b6
> shell/src/test/java/org/apache/sqoop/shell/TestDeleteCommand.java 4165bf0
> shell/src/test/java/org/apache/sqoop/shell/TestDisableCommand.java a236685
> shell/src/test/java/org/apache/sqoop/shell/TestEnableCommand.java 6ce78eb
> shell/src/test/java/org/apache/sqoop/shell/TestGrantCommand.java 9f7f5b8
> shell/src/test/java/org/apache/sqoop/shell/TestRevokeCommand.java 88f04f2
> shell/src/test/java/org/apache/sqoop/shell/TestSetCommand.java b231cf2
> shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 6463bd5
> shell/src/test/java/org/apache/sqoop/shell/TestStartCommand.java b55b087
> shell/src/test/java/org/apache/sqoop/shell/TestStatusCommand.java 9fac463
> shell/src/test/java/org/apache/sqoop/shell/TestStopCommand.java e2bc6b8
> shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java f5062da
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
>
> Diff: https://reviews.apache.org/r/41827/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 41827: Sqoop2: Sqoop shell is accepting non
existing arguments
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41827/#review112744
-----------------------------------------------------------
shell/src/test/java/org/apache/sqoop/shell/TestCloneCommand.java (line 50)
<https://reviews.apache.org/r/41827/#comment173237>
Can we import the individual functions/methods so that we can do just "fail()" or assertTrue() as we have in the other test cases?
shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java (line 432)
<https://reviews.apache.org/r/41827/#comment173238>
I'm wondering why this change from PRINCIPAL to PRIVILEGE?
- Jarek Cecho
On Jan. 5, 2016, 1:12 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41827/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 1:12 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2763
> https://issues.apache.org/jira/browse/SQOOP-2763
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> We happily accept non-existing arguments in the shell which is highly deceptive:
> sqoop:000> set server --name x
> Server is set successfully
> sqoop:000>
> or
> sqoop:000> show connector --please
> ...
> sqoop:000>
> We should throw an exception or something if one is using incorrect/non-existing arguments.
>
>
> Diffs
> -----
>
> common/pom.xml 078a785
> common/src/main/java/org/apache/sqoop/cli/SqoopGnuParser.java PRE-CREATION
> shell/pom.xml 1949a8e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 0845d8e
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java 97b6e3b
> shell/src/test/java/org/apache/sqoop/shell/TestCloneCommand.java 53303af
> shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 1f559b6
> shell/src/test/java/org/apache/sqoop/shell/TestDeleteCommand.java 4165bf0
> shell/src/test/java/org/apache/sqoop/shell/TestDisableCommand.java a236685
> shell/src/test/java/org/apache/sqoop/shell/TestEnableCommand.java 6ce78eb
> shell/src/test/java/org/apache/sqoop/shell/TestGrantCommand.java 9f7f5b8
> shell/src/test/java/org/apache/sqoop/shell/TestRevokeCommand.java 88f04f2
> shell/src/test/java/org/apache/sqoop/shell/TestSetCommand.java b231cf2
> shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 6463bd5
> shell/src/test/java/org/apache/sqoop/shell/TestStartCommand.java b55b087
> shell/src/test/java/org/apache/sqoop/shell/TestStatusCommand.java 9fac463
> shell/src/test/java/org/apache/sqoop/shell/TestStopCommand.java e2bc6b8
> shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java f5062da
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
>
> Diff: https://reviews.apache.org/r/41827/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 41827: Sqoop2: Sqoop shell is accepting non
existing arguments
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41827/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 1:12 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2763
https://issues.apache.org/jira/browse/SQOOP-2763
Repository: sqoop-sqoop2
Description
-------
We happily accept non-existing arguments in the shell which is highly deceptive:
sqoop:000> set server --name x
Server is set successfully
sqoop:000>
or
sqoop:000> show connector --please
...
sqoop:000>
We should throw an exception or something if one is using incorrect/non-existing arguments.
Diffs (updated)
-----
common/pom.xml 078a785
common/src/main/java/org/apache/sqoop/cli/SqoopGnuParser.java PRE-CREATION
shell/pom.xml 1949a8e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 0845d8e
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java 97b6e3b
shell/src/test/java/org/apache/sqoop/shell/TestCloneCommand.java 53303af
shell/src/test/java/org/apache/sqoop/shell/TestCreateCommand.java 1f559b6
shell/src/test/java/org/apache/sqoop/shell/TestDeleteCommand.java 4165bf0
shell/src/test/java/org/apache/sqoop/shell/TestDisableCommand.java a236685
shell/src/test/java/org/apache/sqoop/shell/TestEnableCommand.java 6ce78eb
shell/src/test/java/org/apache/sqoop/shell/TestGrantCommand.java 9f7f5b8
shell/src/test/java/org/apache/sqoop/shell/TestRevokeCommand.java 88f04f2
shell/src/test/java/org/apache/sqoop/shell/TestSetCommand.java b231cf2
shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 6463bd5
shell/src/test/java/org/apache/sqoop/shell/TestStartCommand.java b55b087
shell/src/test/java/org/apache/sqoop/shell/TestStatusCommand.java 9fac463
shell/src/test/java/org/apache/sqoop/shell/TestStopCommand.java e2bc6b8
shell/src/test/java/org/apache/sqoop/shell/TestUpdateCommand.java f5062da
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
Diff: https://reviews.apache.org/r/41827/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 41827: Sqoop2: Sqoop shell is accepting non
existing arguments
Posted by Dian Fu <di...@gmail.com>.
> On Dec. 31, 2015, 2:13 p.m., Jarek Cecho wrote:
> > Looks good to me. Precommit hook complained about failing unit test TestShowCommand. Can you look into why it's failing?
> >
> > Otherwise I'm +1.
Hi Jarcec,
Thanks a lot for the review. Updated the patch.
- Dian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41827/#review112390
-----------------------------------------------------------
On Dec. 31, 2015, 7:43 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41827/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2015, 7:43 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2763
> https://issues.apache.org/jira/browse/SQOOP-2763
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> We happily accept non-existing arguments in the shell which is highly deceptive:
> sqoop:000> set server --name x
> Server is set successfully
> sqoop:000>
> or
> sqoop:000> show connector --please
> ...
> sqoop:000>
> We should throw an exception or something if one is using incorrect/non-existing arguments.
>
>
> Diffs
> -----
>
> common/pom.xml 078a785
> common/src/main/java/org/apache/sqoop/cli/SqoopGnuParser.java PRE-CREATION
> shell/pom.xml 1949a8e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 0845d8e
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java 97b6e3b
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
>
> Diff: https://reviews.apache.org/r/41827/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 41827: Sqoop2: Sqoop shell is accepting non
existing arguments
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41827/#review112390
-----------------------------------------------------------
Looks good to me. Precommit hook complained about failing unit test TestShowCommand. Can you look into why it's failing?
Otherwise I'm +1.
- Jarek Cecho
On Dec. 31, 2015, 7:43 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41827/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2015, 7:43 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2763
> https://issues.apache.org/jira/browse/SQOOP-2763
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> We happily accept non-existing arguments in the shell which is highly deceptive:
> sqoop:000> set server --name x
> Server is set successfully
> sqoop:000>
> or
> sqoop:000> show connector --please
> ...
> sqoop:000>
> We should throw an exception or something if one is using incorrect/non-existing arguments.
>
>
> Diffs
> -----
>
> common/pom.xml 078a785
> common/src/main/java/org/apache/sqoop/cli/SqoopGnuParser.java PRE-CREATION
> shell/pom.xml 1949a8e
> shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 0845d8e
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java 97b6e3b
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
>
> Diff: https://reviews.apache.org/r/41827/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>