[jira] [Comment Edited] (TS-2881) Redirection handling broken

["Sudheer Vinukonda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14021023#comment-14021023 ] 

Sudheer Vinukonda edited comment on TS-2881 at 6/7/14 11:38 PM:
----------------------------------------------------------------

The bug is that, redirect_url is initialized in HttpSM::do_redirect(), but, HttpSM::is_redirect_required() doesn't trigger do_redirect() if, redirect_url is not set. Indeed, this was an issue introduced when cleaning up the code during 56fbfdd2.

The bug is fairly easy to test, since, ATS simply returns the 3xx response to client, without trying to follow it (even, when redirect is enabled). Will try to add some tests later.




was (Author: sudheerv):
The bug is that, redirect_url is initialized in HttpSM::do_redirect(), but, HttpSM::is_redirect_required() doesn't trigger do_redirect() if, redirect_url is not set. Indeed, this was an issue introduced when cleaning up the code during 56fbfdd2.

The bug is fairly easy to test, since, ATS simply returns the 3xx to the client, without following it (even, when redirect is enabled). Will try to add some tests later.



> Redirection handling broken
> ---------------------------
>
>                 Key: TS-2881
>                 URL: https://issues.apache.org/jira/browse/TS-2881
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: Sudheer Vinukonda
>            Assignee: Bryan Call
>             Fix For: 5.0.0
>
>         Attachments: ts2881.diff
>
>
> Redirection handling is broken in master.



--
This message was sent by Atlassian JIRA
(v6.2#6252)