You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/01 17:41:15 UTC
[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas
splett2 commented on a change in pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#discussion_r533600431
##########
File path: clients/src/main/java/org/apache/kafka/common/quota/ClientQuotaEntity.java
##########
@@ -32,6 +32,7 @@
*/
public static final String USER = "user";
public static final String CLIENT_ID = "client-id";
+ public static final String IP = "IP";
Review comment:
I have no objection to editing the KIP to changing this (and other uses of IP) to lower case, I just made it upper case because the original iteration of IP quotas in KIP-612 had IP in upper-case.
@apovzner @dajac for any thoughts on upper vs lower.
FWIW, the ConfigCommand help output is better ordered when IP is in lower-case due to how it sorts flags.
##########
File path: clients/src/main/java/org/apache/kafka/common/quota/ClientQuotaEntity.java
##########
@@ -32,6 +32,7 @@
*/
public static final String USER = "user";
public static final String CLIENT_ID = "client-id";
+ public static final String IP = "IP";
Review comment:
I have no objection to editing the KIP to changing this (and other uses of IP) to lower case, I just made it upper case because the original iteration of IP quotas in KIP-612 had IP in upper-case.
@apovzner @dajac for any thoughts on upper vs lower.
FWIW, the `ConfigCommand` help output is better ordered when IP is in lower-case due to how it sorts flags.
##########
File path: clients/src/main/java/org/apache/kafka/common/quota/ClientQuotaEntity.java
##########
@@ -32,6 +32,7 @@
*/
public static final String USER = "user";
public static final String CLIENT_ID = "client-id";
+ public static final String IP = "IP";
Review comment:
I have no objection to editing the KIP to changing this (and other uses of IP) to lower case, I just made it upper case because the original iteration of IP quotas in KIP-612 had IP in upper-case.
@apovzner @dajac for any thoughts on upper vs lower.
FWIW, the `kafka-configs` help output is better ordered when IP is in lower-case due to how it sorts flags.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org