You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/11 22:07:30 UTC

[GitHub] [commons-codec] garydgregory commented on a change in pull request #44: Update DigestUtils.java

garydgregory commented on a change in pull request #44:
URL: https://github.com/apache/commons-codec/pull/44#discussion_r541346067



##########
File path: src/main/java/org/apache/commons/codec/digest/DigestUtils.java
##########
@@ -192,6 +192,7 @@ public static MessageDigest getDigest(final String algorithm) {
      */
     public static MessageDigest getDigest(final String algorithm, final MessageDigest defaultMessageDigest) {
         try {
+            /** potential insecure algorithm (MD2, MD5, SHA1, SHA256) called here */

Review comment:
       @YYTVicky 
   This would better done in the method Javadoc for the algorithm param.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org