[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3801: ARTEMIS-3523: Expose replay through AddressControl

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3801:
URL: https://github.com/apache/activemq-artemis/pull/3801#discussion_r731814409



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -4443,7 +4443,7 @@ public void reloadConfigurationFile() throws Exception {
 
    @Override
    public void replay(String address, String target, String filter) throws Exception {
-      server.replay(null, null, address, target, filter);
+      server.replay(null, null, this.getAddressInfo(address), target, filter);

Review comment:
       the change required is a bit more than just this...
   
   You have to add a method replay on ActiveMQAddressControl / ActiveMQAddressControlImpl
   
   and delegate it to ActiveMQServerImpl (same one called by the ActiveMQServerControl)
   
   
   you don't need to get the addressInfo on this case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org