You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/09/01 13:29:45 UTC

[jira] Created: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Queues create a new thread pool which is not closed on broker shutdown
----------------------------------------------------------------------

                 Key: QPID-1266
                 URL: https://issues.apache.org/jira/browse/QPID-1266
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker
    Affects Versions: M3
            Reporter: Martin Ritchie
             Fix For: M4


Summary:

AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 

Suggestion:

Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-1266:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634090#action_12634090 ] 

Martin Ritchie commented on QPID-1266:
--------------------------------------

My code must have changed(or not updated) as the line numbers don't match up. Lets chat about this when you return.

> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aidan Skinner updated QPID-1266:
--------------------------------

    Status: Open  (was: Ready To Review)

Test logs error rather than throwing.

SimpleAMQQueue.java: has essentially empty else{} block on line 1110.



> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Aidan Skinner
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-1266:
------------------------------------

    Assignee: Aidan Skinner  (was: Martin Ritchie)

Aidan can you review this please.

Test : SimpleAMQQueueThreadPoolTest

> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Aidan Skinner
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aidan Skinner reassigned QPID-1266:
-----------------------------------

    Assignee: Martin Ritchie  (was: Aidan Skinner)

> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-1266:
------------------------------------

    Assignee: Martin Ritchie

> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635776#action_12635776 ] 

Martin Ritchie commented on QPID-1266:
--------------------------------------

QPID-1269 is the JIRA that talks to the registration of VirtualHosts.

> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-1266:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aidan Skinner resolved QPID-1266.
---------------------------------

    Resolution: Fixed
      Assignee: Martin Ritchie  (was: Aidan Skinner)

> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (QPID-1266) Queues create a new thread pool which is not closed on broker shutdown

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-1266:
------------------------------------

    Assignee: Aidan Skinner  (was: Martin Ritchie)

Hey Aidan, can you cast your eye over this again. Thanks.

> Queues create a new thread pool which is not closed on broker shutdown
> ----------------------------------------------------------------------
>
>                 Key: QPID-1266
>                 URL: https://issues.apache.org/jira/browse/QPID-1266
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Aidan Skinner
>             Fix For: M4
>
>
> Summary:
> AMQQueues create a new ReferenceCountingExecutorService which is not cleanly shutdown. This will result in processes that create an AMQQueue instance not exiting. 
> Suggestion:
> Add a stop method to the queue which can then be called as part of the broker shutdown code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.