[GitHub] [druid] suneet-s opened a new pull request #9273: Add an IndexedTableLoader Extension

[GitBox <gi...@apache.org>]

suneet-s opened a new pull request #9273: Add an IndexedTableLoader Extension
URL: https://github.com/apache/druid/pull/9273
 
 
   Create an extension that can load an IndexedTable from a provided
   IndexIngestionSpec
   
   The extension attemps to load the IngestionSpec on startup and reads the rows
   into an RowBasedIndexedTable
   
   This change makes the LifecycleLock non final for easier testing
   
   Follow up patches:
   - Hook up the RowBasedIndexTable to a DataSource so that it can be queried
   - Refactor the RowBasedIndexTable to accept a row so that it can load the
   index table in just one pass over the rows
   - Introduce an IndexedTableResource so that the tables can be loaded via an
   API instead of just through config
   - Refactor the IngestionSpec so that any spec can provide an iterator over
   the input source. This will allow the extension to read the IndexedTable from
   any format.
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `MyFoo`
    * `OurBar`
    * `TheirBaz`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s closed pull request #9273: Add an IndexedTableLoader Extension

[GitBox <gi...@apache.org>]

suneet-s closed pull request #9273: Add an IndexedTableLoader Extension
URL: https://github.com/apache/druid/pull/9273
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org