[GitHub] garrensmith commented on a change in pull request #1148: [partitioned-dbs] Updates to sidebar

[GitBox <gi...@apache.org>]

garrensmith commented on a change in pull request #1148: [partitioned-dbs] Updates to sidebar
URL: https://github.com/apache/couchdb-fauxton/pull/1148#discussion_r229591166
 
 

 ##########
 File path: app/addons/documents/base.js
 ##########
 @@ -42,14 +42,18 @@ function getQueryParam (query) {
   return query;
 }
 
+function partitionUrlComponent(partitionKey) {
+  return partitionKey ? '/_partition/' + partitionKey : '';
+}
+
 FauxtonAPI.registerUrls('allDocs', {
   server: function (id, query) {
     /** XXX DEPRECATED: use allDocsSanitized **/
     return Helpers.getServerUrl('/' + id + '/_all_docs' + getQueryParam(query));
   },
-  app: function (id, query) {
+  app: function (id, partitionKey, query) {
     /** XXX DEPRECATED: use allDocsSanitized **/
 
 Review comment:
   Are these truly deprecated. If so we should remove them and use the correct ones. Or remove the comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services