You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Ross Gardler (JIRA)" <ji...@apache.org> on 2005/10/04 22:42:49 UTC

[jira] Created: (FOR-701) Missing locatoinmap entry gives poor error

Missing locatoinmap entry gives poor error
------------------------------------------

         Key: FOR-701
         URL: http://issues.apache.org/jira/browse/FOR-701
     Project: Forrest
        Type: Bug
    Reporter: Ross Gardler
    Priority: Critical
     Fix For: 0.8-dev


If there is no locationmap entry for a resource we get a "resource not found" error. This is fine if it is the actual source file that is missing. However, now that we are using the LM to find other intermediate resources, such as stylesheets etc. it can be misleading.

We need to throw a meaningful error when when a resource cannot be found.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Updated: (FOR-701) Missing locationmap entry gives poor error

Posted by Ross Gardler <rg...@apache.org>.
David Crossley wrote:
> This was referring to the message that is shown in the browser.
> Is that improved now?

No, that is covered in http://issues.apache.org/jira/browse/FOR-701

Note that this is blocked by a Cocoon issue: 
http://issues.apache.org/jira/browse/COCOON-1542

Ross


Re: [jira] Updated: (FOR-701) Missing locationmap entry gives poor error

Posted by David Crossley <cr...@apache.org>.
This was referring to the message that is shown in the browser.
Is that improved now?

-David

Ross Gardler (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/FOR-701?page=all ]
> 
> Ross Gardler updated FOR-701:
> -----------------------------
> 
>     Fix Version:     (was: 0.8-dev)
>        Priority: Minor  (was: Critical)
> 
> Reducing priority and moving to an unreleased version. Logs now give meaningful information.
> 
> > Missing locationmap entry gives poor error
> > ------------------------------------------
> >
> >          Key: FOR-701
> >          URL: http://issues.apache.org/jira/browse/FOR-701
> >      Project: Forrest
> >         Type: Bug
> >   Components: Locationmap
> >     Reporter: Ross Gardler
> >     Priority: Minor
> 
> >
> > If there is no locationmap entry for a resource we get a "resource not found" error. This is fine if it is the actual source file that is missing. However, now that we are using the LM to find other intermediate resources, such as stylesheets etc. it can be misleading.
> > We need to throw a meaningful error when when a resource cannot be found.
> 
> -- 
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira

[jira] Closed: (FOR-701) Missing locationmap entry gives poor error

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ross Gardler closed FOR-701.
----------------------------

    Resolution: Fixed
      Assignee: Ross Gardler

Needs improvement, but at least the error now says the problem is in the locationmap!

> Missing locationmap entry gives poor error
> ------------------------------------------
>
>                 Key: FOR-701
>                 URL: https://issues.apache.org/jira/browse/FOR-701
>             Project: Forrest
>          Issue Type: Bug
>          Components: Locationmap
>            Reporter: Ross Gardler
>         Assigned To: Ross Gardler
>            Priority: Minor
>
> If there is no locationmap entry for a resource we get a "resource not found" error. This is fine if it is the actual source file that is missing. However, now that we are using the LM to find other intermediate resources, such as stylesheets etc. it can be misleading.
> We need to throw a meaningful error when when a resource cannot be found.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FOR-701) Missing locationmap entry gives poor error

Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-701?page=all ]

Tim Williams updated FOR-701:
-----------------------------

    Component: Locationmap

Indicated "locationmap" component

> Missing locationmap entry gives poor error
> ------------------------------------------
>
>          Key: FOR-701
>          URL: http://issues.apache.org/jira/browse/FOR-701
>      Project: Forrest
>         Type: Bug
>   Components: Locationmap
>     Reporter: Ross Gardler
>     Priority: Critical
>      Fix For: 0.8-dev

>
> If there is no locationmap entry for a resource we get a "resource not found" error. This is fine if it is the actual source file that is missing. However, now that we are using the LM to find other intermediate resources, such as stylesheets etc. it can be misleading.
> We need to throw a meaningful error when when a resource cannot be found.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-701) Missing locationmap entry gives poor error

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-701?page=comments#action_12359950 ] 

Ross Gardler commented on FOR-701:
----------------------------------

Now that Forest throws an exception when the final location returned is a null we can (probably) trap this error in our sitemap and provide a more meaningful error message. It is unlikely that the Cocoon issue will be resolved as it has wider implications and side-effects.

> Missing locationmap entry gives poor error
> ------------------------------------------
>
>          Key: FOR-701
>          URL: http://issues.apache.org/jira/browse/FOR-701
>      Project: Forrest
>         Type: Bug
>   Components: Locationmap
>     Reporter: Ross Gardler
>     Priority: Minor

>
> If there is no locationmap entry for a resource we get a "resource not found" error. This is fine if it is the actual source file that is missing. However, now that we are using the LM to find other intermediate resources, such as stylesheets etc. it can be misleading.
> We need to throw a meaningful error when when a resource cannot be found.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-701) Missing locationmap entry gives poor error

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-701?page=all ]

Ross Gardler updated FOR-701:
-----------------------------

    Fix Version:     (was: 0.8-dev)
       Priority: Minor  (was: Critical)

Reducing priority and moving to an unreleased version. Logs now give meaningful information.

> Missing locationmap entry gives poor error
> ------------------------------------------
>
>          Key: FOR-701
>          URL: http://issues.apache.org/jira/browse/FOR-701
>      Project: Forrest
>         Type: Bug
>   Components: Locationmap
>     Reporter: Ross Gardler
>     Priority: Minor

>
> If there is no locationmap entry for a resource we get a "resource not found" error. This is fine if it is the actual source file that is missing. However, now that we are using the LM to find other intermediate resources, such as stylesheets etc. it can be misleading.
> We need to throw a meaningful error when when a resource cannot be found.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Reopened: (FOR-701) Missing locationmap entry gives poor error

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ross Gardler reopened FOR-701:
------------------------------

      Assignee:     (was: Ross Gardler)

Reopened as the fix prevented broken-links.xml from being generated.

the fix is currently commented out in the root sitemap.

> Missing locationmap entry gives poor error
> ------------------------------------------
>
>                 Key: FOR-701
>                 URL: https://issues.apache.org/jira/browse/FOR-701
>             Project: Forrest
>          Issue Type: Bug
>          Components: Locationmap
>            Reporter: Ross Gardler
>            Priority: Minor
>
> If there is no locationmap entry for a resource we get a "resource not found" error. This is fine if it is the actual source file that is missing. However, now that we are using the LM to find other intermediate resources, such as stylesheets etc. it can be misleading.
> We need to throw a meaningful error when when a resource cannot be found.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-701) Missing locationmap entry gives poor error

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482975 ] 

Ross Gardler commented on FOR-701:
----------------------------------

I've added some basic error handling for the ResourceNotFound case we get when the locationmap fails to resolve a request.

It's still not great but it is a small improvement and, more importantly, paves the way for better error reporting using exception-to-html.xsl

> Missing locationmap entry gives poor error
> ------------------------------------------
>
>                 Key: FOR-701
>                 URL: https://issues.apache.org/jira/browse/FOR-701
>             Project: Forrest
>          Issue Type: Bug
>          Components: Locationmap
>            Reporter: Ross Gardler
>            Priority: Minor
>
> If there is no locationmap entry for a resource we get a "resource not found" error. This is fine if it is the actual source file that is missing. However, now that we are using the LM to find other intermediate resources, such as stylesheets etc. it can be misleading.
> We need to throw a meaningful error when when a resource cannot be found.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FOR-701) Missing locationmap entry gives poor error

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-701?page=all ]

Ross Gardler updated FOR-701:
-----------------------------

    Summary: Missing locationmap entry gives poor error  (was: Missing locatoinmap entry gives poor error)

> Missing locationmap entry gives poor error
> ------------------------------------------
>
>          Key: FOR-701
>          URL: http://issues.apache.org/jira/browse/FOR-701
>      Project: Forrest
>         Type: Bug
>     Reporter: Ross Gardler
>     Priority: Critical
>      Fix For: 0.8-dev

>
> If there is no locationmap entry for a resource we get a "resource not found" error. This is fine if it is the actual source file that is missing. However, now that we are using the LM to find other intermediate resources, such as stylesheets etc. it can be misleading.
> We need to throw a meaningful error when when a resource cannot be found.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira