You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/21 18:29:11 UTC
[GitHub] [camel] k-jamroz opened a new pull request #6806: CAMEL-17536 Fixed: ServicePool.doStop hangs during shutdown
k-jamroz opened a new pull request #6806:
URL: https://github.com/apache/camel/pull/6806
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
Access to `cache` is synchronized. I was unsure who is responsible for synchronization when `cache` is `LRUCache`, not a simple map and left `cleanUp` not synchronized. If `LRUCache` is supposed to be thread-safe, then added synchronization is redundant for `LRUCache` and could be applied conditionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus closed pull request #6806: CAMEL-17536 Fixed: ServicePool.doStop hangs during shutdown
Posted by GitBox <gi...@apache.org>.
davsclaus closed pull request #6806:
URL: https://github.com/apache/camel/pull/6806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] k-jamroz commented on pull request #6806: CAMEL-17536 Fixed: ServicePool.doStop hangs during shutdown
Posted by GitBox <gi...@apache.org>.
k-jamroz commented on pull request #6806:
URL: https://github.com/apache/camel/pull/6806#issuecomment-1020212874
Thanks for looking into it. I believe that the optimization is incorrect, because race condition is not always due to recipientlist processing during shutdown. I will create another issue for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6806: CAMEL-17536 Fixed: ServicePool.doStop hangs during shutdown
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6806:
URL: https://github.com/apache/camel/pull/6806#issuecomment-1019439787
Thanks for this PR. I modified it a bit to only use synchronized in acquire if we are stopping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org