You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@helix.apache.org by kishore g <g....@gmail.com> on 2014/02/12 02:31:03 UTC
Apache git and github integration
Hi Guys,
We can have much tighter integration between github and apache git.
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
Should we opt in?
thanks,
Kishore G
RE: Apache git and github integration
Posted by bo...@schulman.com.
+1
However, are there any negatives we aren't considering? I can't think of any.
- Bob
>
> +1 for better GitHub integration.
> Date: Tue, 11 Feb 2014 17:31:03 -0800
> Subject: Apache git and github integration
> From: g.kishore@gmail.com
> To: dev@helix.apache.org; user@helix.apache.org
>
> Hi Guys,
>
> We can have much tighter integration between github and apache git.
>
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>
>
> Should we opt in?
>
> thanks,
> Kishore G
>
RE: Apache git and github integration
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
+1 for better GitHub integration.
Date: Tue, 11 Feb 2014 17:31:03 -0800
Subject: Apache git and github integration
From: g.kishore@gmail.com
To: dev@helix.apache.org; user@helix.apache.org
Hi Guys,
We can have much tighter integration between github and apache git.
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
Should we opt in?
thanks,
Kishore G
RE: Apache git and github integration
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
That's the idea. People in the past who have made contributions needed to go through the usual channels, which is annoying for them if they're just sending one-off patches.
Kanak
----------------------------------------
> Date: Thu, 13 Feb 2014 11:02:08 -0800
> Subject: Re: Apache git and github integration
> From: henry.saputra@gmail.com
> To: dev@helix.apache.org
>
> So I guess Helix dev start accepting github pull requests from the ASF
> github mirror? =)
>
> - Henry
>
> On Thu, Feb 13, 2014 at 10:51 AM, Kanak Biscuitwala <ka...@hotmail.com> wrote:
>> Created https://issues.apache.org/jira/browse/INFRA-7318
>>
>>
>>
>> ----------------------------------------
>>> From: kanak.b@hotmail.com
>>> To: dev@helix.apache.org
>>> Subject: RE: Apache git and github integration
>>> Date: Wed, 12 Feb 2014 15:32:19 -0800
>>>
>>> Yeah I was referring to the former case. It looks like they took the PR as a patch, applied it to the ASF repo, and added "(closes &num)" to the commit message.
>>>
>>> It definitely makes sense that a PR not accepted and committed requires originator action.
>>>
>>> ----------------------------------------
>>>> Date: Wed, 12 Feb 2014 15:02:01 -0800
>>>> Subject: Re: Apache git and github integration
>>>> From: henry.saputra@gmail.com
>>>> To: dev@helix.apache.org
>>>>
>>>> Are the PR merged to the repo? If the PR merged to the ASF git repo
>>>> then once the mirror github is sync it will automatically closed.
>>>>
>>>> I was referring to the PRs that are not merged or somehow solved
>>>> differently. Then the original authors need to close them.
>>>>
>>>> - Henry
>>>>
>>>> On Wed, Feb 12, 2014 at 2:36 PM, Kanak Biscuitwala <ka...@hotmail.com> wrote:
>>>>> Henry,
>>>>>
>>>>> I've seen other ASF projects be able to use a bot to close the pull request by putting "closes &PRNUM" in the commit log. Does that still apply, or is it something else set up by those projects?
>>>>>
>>>>> Thanks,
>>>>> Kanak
>>>>>
>>>>>> Date: Wed, 12 Feb 2014 14:10:07 -0800
>>>>>> Subject: Re: Apache git and github integration
>>>>>> From: henry.saputra@gmail.com
>>>>>> To: dev@helix.apache.org
>>>>>>
>>>>>> The only limitation is that the committers still need to merge
>>>>>> manually to ASF Git repo instead of the mirror github repo.
>>>>>> And it needs to maintain the actual comment and author of the commits
>>>>>> from the original PR for "karma" recording =)
>>>>>>
>>>>>> And also if any pull request is not accepted or need update the
>>>>>> committers cannot close the PRs. Only the original PRs creators can
>>>>>> close them.
>>>>>>
>>>>>> - Henry
>>>>>>
>>>>>> On Tue, Feb 11, 2014 at 5:31 PM, kishore g <g....@gmail.com> wrote:
>>>>>>> Hi Guys,
>>>>>>>
>>>>>>> We can have much tighter integration between github and apache git.
>>>>>>>
>>>>>>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>>>>>>>
>>>>>>> Should we opt in?
>>>>>>>
>>>>>>> thanks,
>>>>>>> Kishore G
Re: Apache git and github integration
Posted by Henry Saputra <he...@gmail.com>.
So I guess Helix dev start accepting github pull requests from the ASF
github mirror? =)
- Henry
On Thu, Feb 13, 2014 at 10:51 AM, Kanak Biscuitwala <ka...@hotmail.com> wrote:
> Created https://issues.apache.org/jira/browse/INFRA-7318
>
>
>
> ----------------------------------------
>> From: kanak.b@hotmail.com
>> To: dev@helix.apache.org
>> Subject: RE: Apache git and github integration
>> Date: Wed, 12 Feb 2014 15:32:19 -0800
>>
>> Yeah I was referring to the former case. It looks like they took the PR as a patch, applied it to the ASF repo, and added "(closes &num)" to the commit message.
>>
>> It definitely makes sense that a PR not accepted and committed requires originator action.
>>
>> ----------------------------------------
>>> Date: Wed, 12 Feb 2014 15:02:01 -0800
>>> Subject: Re: Apache git and github integration
>>> From: henry.saputra@gmail.com
>>> To: dev@helix.apache.org
>>>
>>> Are the PR merged to the repo? If the PR merged to the ASF git repo
>>> then once the mirror github is sync it will automatically closed.
>>>
>>> I was referring to the PRs that are not merged or somehow solved
>>> differently. Then the original authors need to close them.
>>>
>>> - Henry
>>>
>>> On Wed, Feb 12, 2014 at 2:36 PM, Kanak Biscuitwala <ka...@hotmail.com> wrote:
>>>> Henry,
>>>>
>>>> I've seen other ASF projects be able to use a bot to close the pull request by putting "closes &PRNUM" in the commit log. Does that still apply, or is it something else set up by those projects?
>>>>
>>>> Thanks,
>>>> Kanak
>>>>
>>>>> Date: Wed, 12 Feb 2014 14:10:07 -0800
>>>>> Subject: Re: Apache git and github integration
>>>>> From: henry.saputra@gmail.com
>>>>> To: dev@helix.apache.org
>>>>>
>>>>> The only limitation is that the committers still need to merge
>>>>> manually to ASF Git repo instead of the mirror github repo.
>>>>> And it needs to maintain the actual comment and author of the commits
>>>>> from the original PR for "karma" recording =)
>>>>>
>>>>> And also if any pull request is not accepted or need update the
>>>>> committers cannot close the PRs. Only the original PRs creators can
>>>>> close them.
>>>>>
>>>>> - Henry
>>>>>
>>>>> On Tue, Feb 11, 2014 at 5:31 PM, kishore g <g....@gmail.com> wrote:
>>>>>> Hi Guys,
>>>>>>
>>>>>> We can have much tighter integration between github and apache git.
>>>>>>
>>>>>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>>>>>>
>>>>>> Should we opt in?
>>>>>>
>>>>>> thanks,
>>>>>> Kishore G
RE: Apache git and github integration
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
Created https://issues.apache.org/jira/browse/INFRA-7318
----------------------------------------
> From: kanak.b@hotmail.com
> To: dev@helix.apache.org
> Subject: RE: Apache git and github integration
> Date: Wed, 12 Feb 2014 15:32:19 -0800
>
> Yeah I was referring to the former case. It looks like they took the PR as a patch, applied it to the ASF repo, and added "(closes &num)" to the commit message.
>
> It definitely makes sense that a PR not accepted and committed requires originator action.
>
> ----------------------------------------
>> Date: Wed, 12 Feb 2014 15:02:01 -0800
>> Subject: Re: Apache git and github integration
>> From: henry.saputra@gmail.com
>> To: dev@helix.apache.org
>>
>> Are the PR merged to the repo? If the PR merged to the ASF git repo
>> then once the mirror github is sync it will automatically closed.
>>
>> I was referring to the PRs that are not merged or somehow solved
>> differently. Then the original authors need to close them.
>>
>> - Henry
>>
>> On Wed, Feb 12, 2014 at 2:36 PM, Kanak Biscuitwala <ka...@hotmail.com> wrote:
>>> Henry,
>>>
>>> I've seen other ASF projects be able to use a bot to close the pull request by putting "closes &PRNUM" in the commit log. Does that still apply, or is it something else set up by those projects?
>>>
>>> Thanks,
>>> Kanak
>>>
>>>> Date: Wed, 12 Feb 2014 14:10:07 -0800
>>>> Subject: Re: Apache git and github integration
>>>> From: henry.saputra@gmail.com
>>>> To: dev@helix.apache.org
>>>>
>>>> The only limitation is that the committers still need to merge
>>>> manually to ASF Git repo instead of the mirror github repo.
>>>> And it needs to maintain the actual comment and author of the commits
>>>> from the original PR for "karma" recording =)
>>>>
>>>> And also if any pull request is not accepted or need update the
>>>> committers cannot close the PRs. Only the original PRs creators can
>>>> close them.
>>>>
>>>> - Henry
>>>>
>>>> On Tue, Feb 11, 2014 at 5:31 PM, kishore g <g....@gmail.com> wrote:
>>>>> Hi Guys,
>>>>>
>>>>> We can have much tighter integration between github and apache git.
>>>>>
>>>>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>>>>>
>>>>> Should we opt in?
>>>>>
>>>>> thanks,
>>>>> Kishore G
RE: Apache git and github integration
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
Yeah I was referring to the former case. It looks like they took the PR as a patch, applied it to the ASF repo, and added "(closes #num)" to the commit message.
It definitely makes sense that a PR not accepted and committed requires originator action.
----------------------------------------
> Date: Wed, 12 Feb 2014 15:02:01 -0800
> Subject: Re: Apache git and github integration
> From: henry.saputra@gmail.com
> To: dev@helix.apache.org
>
> Are the PR merged to the repo? If the PR merged to the ASF git repo
> then once the mirror github is sync it will automatically closed.
>
> I was referring to the PRs that are not merged or somehow solved
> differently. Then the original authors need to close them.
>
> - Henry
>
> On Wed, Feb 12, 2014 at 2:36 PM, Kanak Biscuitwala <ka...@hotmail.com> wrote:
>> Henry,
>>
>> I've seen other ASF projects be able to use a bot to close the pull request by putting "closes #PRNUM" in the commit log. Does that still apply, or is it something else set up by those projects?
>>
>> Thanks,
>> Kanak
>>
>>> Date: Wed, 12 Feb 2014 14:10:07 -0800
>>> Subject: Re: Apache git and github integration
>>> From: henry.saputra@gmail.com
>>> To: dev@helix.apache.org
>>>
>>> The only limitation is that the committers still need to merge
>>> manually to ASF Git repo instead of the mirror github repo.
>>> And it needs to maintain the actual comment and author of the commits
>>> from the original PR for "karma" recording =)
>>>
>>> And also if any pull request is not accepted or need update the
>>> committers cannot close the PRs. Only the original PRs creators can
>>> close them.
>>>
>>> - Henry
>>>
>>> On Tue, Feb 11, 2014 at 5:31 PM, kishore g <g....@gmail.com> wrote:
>>>> Hi Guys,
>>>>
>>>> We can have much tighter integration between github and apache git.
>>>>
>>>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>>>>
>>>> Should we opt in?
>>>>
>>>> thanks,
>>>> Kishore G
Re: Apache git and github integration
Posted by Henry Saputra <he...@gmail.com>.
Are the PR merged to the repo? If the PR merged to the ASF git repo
then once the mirror github is sync it will automatically closed.
I was referring to the PRs that are not merged or somehow solved
differently. Then the original authors need to close them.
- Henry
On Wed, Feb 12, 2014 at 2:36 PM, Kanak Biscuitwala <ka...@hotmail.com> wrote:
> Henry,
>
> I've seen other ASF projects be able to use a bot to close the pull request by putting "closes #PRNUM" in the commit log. Does that still apply, or is it something else set up by those projects?
>
> Thanks,
> Kanak
>
>> Date: Wed, 12 Feb 2014 14:10:07 -0800
>> Subject: Re: Apache git and github integration
>> From: henry.saputra@gmail.com
>> To: dev@helix.apache.org
>>
>> The only limitation is that the committers still need to merge
>> manually to ASF Git repo instead of the mirror github repo.
>> And it needs to maintain the actual comment and author of the commits
>> from the original PR for "karma" recording =)
>>
>> And also if any pull request is not accepted or need update the
>> committers cannot close the PRs. Only the original PRs creators can
>> close them.
>>
>> - Henry
>>
>> On Tue, Feb 11, 2014 at 5:31 PM, kishore g <g....@gmail.com> wrote:
>>> Hi Guys,
>>>
>>> We can have much tighter integration between github and apache git.
>>>
>>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>>>
>>> Should we opt in?
>>>
>>> thanks,
>>> Kishore G
RE: Apache git and github integration
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
Henry,
I've seen other ASF projects be able to use a bot to close the pull request by putting "closes #PRNUM" in the commit log. Does that still apply, or is it something else set up by those projects?
Thanks,
Kanak
> Date: Wed, 12 Feb 2014 14:10:07 -0800
> Subject: Re: Apache git and github integration
> From: henry.saputra@gmail.com
> To: dev@helix.apache.org
>
> The only limitation is that the committers still need to merge
> manually to ASF Git repo instead of the mirror github repo.
> And it needs to maintain the actual comment and author of the commits
> from the original PR for "karma" recording =)
>
> And also if any pull request is not accepted or need update the
> committers cannot close the PRs. Only the original PRs creators can
> close them.
>
> - Henry
>
> On Tue, Feb 11, 2014 at 5:31 PM, kishore g <g....@gmail.com> wrote:
>> Hi Guys,
>>
>> We can have much tighter integration between github and apache git.
>>
>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>>
>> Should we opt in?
>>
>> thanks,
>> Kishore G
Re: Apache git and github integration
Posted by Henry Saputra <he...@gmail.com>.
The only limitation is that the committers still need to merge
manually to ASF Git repo instead of the mirror github repo.
And it needs to maintain the actual comment and author of the commits
from the original PR for "karma" recording =)
And also if any pull request is not accepted or need update the
committers cannot close the PRs. Only the original PRs creators can
close them.
- Henry
On Tue, Feb 11, 2014 at 5:31 PM, kishore g <g....@gmail.com> wrote:
> Hi Guys,
>
> We can have much tighter integration between github and apache git.
>
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>
> Should we opt in?
>
> thanks,
> Kishore G
Re: Apache git and github integration
Posted by Olivier Lamy <ol...@apache.org>.
+1
On 12 February 2014 12:31, kishore g <g....@gmail.com> wrote:
> Hi Guys,
>
> We can have much tighter integration between github and apache git.
>
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>
> Should we opt in?
>
> thanks,
> Kishore G
--
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy
RE: Apache git and github integration
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
+1 for better GitHub integration.
Date: Tue, 11 Feb 2014 17:31:03 -0800
Subject: Apache git and github integration
From: g.kishore@gmail.com
To: dev@helix.apache.org; user@helix.apache.org
Hi Guys,
We can have much tighter integration between github and apache git.
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
Should we opt in?
thanks,
Kishore G