You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by artem-fedorov <gi...@git.apache.org> on 2019/02/04 14:25:42 UTC
[GitHub] jmeter pull request #439: Fix 63055
GitHub user artem-fedorov opened a pull request:
https://github.com/apache/jmeter/pull/439
Fix 63055
https://bz.apache.org/bugzilla/show_bug.cgi?id=63055
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/artem-fedorov/jmeter fix-63055
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/439.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #439
----
commit 2d6b530764017678bd06eea6296b3ca09141575a
Author: Artem Fedorov <ar...@...>
Date: 2019-02-04T13:49:04Z
fix rename sample labels
https://bz.apache.org/bugzilla/show_bug.cgi?id=63055
commit a453a63372d0563a7cf7582ce87193dd7b5d3571
Author: Artem Fedorov <ar...@...>
Date: 2019-02-04T14:19:43Z
fix isRenameSampleLabe()
commit 3b7e2eb8135570e112403aa705b5a48fa6990d93
Author: Artem Fedorov <ar...@...>
Date: 2019-02-04T14:19:48Z
add test
commit 064ac6fb0ae049f7536e487d0b40093858c361fe
Author: Artem Fedorov <ar...@...>
Date: 2019-02-04T14:24:43Z
add changelog
----
---
[GitHub] jmeter issue #439: Fix 63055
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/439
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=h1) Report
> Merging [#439](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/295528a48fdf919d5479e0b91d030d19736adcf7?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `91.3%`.
[](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #439 +/- ##
============================================
+ Coverage 58.57% 58.57% +<.01%
- Complexity 10775 10778 +3
============================================
Files 1206 1206
Lines 77193 77212 +19
Branches 7456 7456
============================================
+ Hits 45213 45230 +17
- Misses 29451 29453 +2
Partials 2529 2529
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/org/apache/jmeter/samplers/TestSampleResult.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvVGVzdFNhbXBsZVJlc3VsdC5qYXZh) | `94.38% <100%> (+0.53%)` | `25 <1> (+1)` | :arrow_up: |
| [.../core/org/apache/jmeter/samplers/SampleResult.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvU2FtcGxlUmVzdWx0LmphdmE=) | `75.51% <66.66%> (-0.12%)` | `135 <4> (+2)` | |
| [...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==) | `54.83% <0%> (-2.16%)` | `15% <0%> (ø)` | |
| [...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==) | `85.49% <0%> (-0.77%)` | `18% <0%> (-1%)` | |
| [...s/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL1BvaXNzb25SYW5kb21UaW1lci5qYXZh) | `78.37% <0%> (+5.4%)` | `10% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=footer). Last update [295528a...d15ed03](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter issue #439: Fix 63055
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/439
Hello @artem-fedorov ,
Can you provide a documentation of new property, it's in properties_reference.xml and we also usually add it commented to jmeter.properties.
Thanks
---
[GitHub] jmeter pull request #439: Fix 63055
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/439
---