You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2015/02/03 07:43:43 UTC

Review Request 30549: SELECT max(bar) FROM foo is broken after ANALYZE ... FOR COLUMNS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30549/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-9397
    https://issues.apache.org/jira/browse/HIVE-9397


Repository: hive-git


Description
-------

These queries produce an error :

{code:sql}
DROP TABLE IF EXISTS foo;

CREATE TABLE foo (id int) STORED AS ORC;

INSERT INTO TABLE foo VALUES (1);
INSERT INTO TABLE foo VALUES (2);
INSERT INTO TABLE foo VALUES (3);
INSERT INTO TABLE foo VALUES (4);
INSERT INTO TABLE foo VALUES (5);

SELECT max(id) FROM foo;

ANALYZE TABLE foo COMPUTE STATISTICS FOR COLUMNS id;

SELECT max(id) FROM foo;
{code}

The last query throws {{org.apache.hive.service.cli.HiveSQLException}}
{noformat}
0: jdbc:hive2://nc-h04:10000/casino> SELECT max(id) FROM foo;
+-------------+--+
|     _c0     |
+-------------+--+
org.apache.hive.service.cli.HiveSQLException: java.lang.ClassCastException
0: jdbc:hive2://nc-h04:10000/casino>
{noformat}


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 6961d7f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java d1118f1 
  ql/src/test/results/clientpositive/metadata_only_queries.q.out 90c76ed 
  ql/src/test/results/clientpositive/metadata_only_queries_with_filters.q.out 5be958f 

Diff: https://reviews.apache.org/r/30549/diff/


Testing
-------


Thanks,

Navis Ryu


Re: Review Request 30549: SELECT max(bar) FROM foo is broken after ANALYZE ... FOR COLUMNS

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30549/#review70897
-----------------------------------------------------------

Ship it!


Ship It!

- Ashutosh Chauhan


On Feb. 4, 2015, 1:43 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30549/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:43 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-9397
>     https://issues.apache.org/jira/browse/HIVE-9397
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> These queries produce an error :
> 
> {code:sql}
> DROP TABLE IF EXISTS foo;
> 
> CREATE TABLE foo (id int) STORED AS ORC;
> 
> INSERT INTO TABLE foo VALUES (1);
> INSERT INTO TABLE foo VALUES (2);
> INSERT INTO TABLE foo VALUES (3);
> INSERT INTO TABLE foo VALUES (4);
> INSERT INTO TABLE foo VALUES (5);
> 
> SELECT max(id) FROM foo;
> 
> ANALYZE TABLE foo COMPUTE STATISTICS FOR COLUMNS id;
> 
> SELECT max(id) FROM foo;
> {code}
> 
> The last query throws {{org.apache.hive.service.cli.HiveSQLException}}
> {noformat}
> 0: jdbc:hive2://nc-h04:10000/casino> SELECT max(id) FROM foo;
> +-------------+--+
> |     _c0     |
> +-------------+--+
> org.apache.hive.service.cli.HiveSQLException: java.lang.ClassCastException
> 0: jdbc:hive2://nc-h04:10000/casino>
> {noformat}
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 6961d7f 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java d1118f1 
>   ql/src/test/results/clientpositive/metadata_only_queries.q.out 90c76ed 
>   ql/src/test/results/clientpositive/metadata_only_queries_with_filters.q.out 5be958f 
>   ql/src/test/results/clientpositive/spark/metadata_only_queries.q.out 9d6a404 
>   ql/src/test/results/clientpositive/spark/metadata_only_queries_with_filters.q.out 5be958f 
>   ql/src/test/results/clientpositive/tez/metadata_only_queries.q.out 8c0bccb 
> 
> Diff: https://reviews.apache.org/r/30549/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Re: Review Request 30549: SELECT max(bar) FROM foo is broken after ANALYZE ... FOR COLUMNS

Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30549/
-----------------------------------------------------------

(Updated Feb. 4, 2015, 1:43 a.m.)


Review request for hive.


Changes
-------

Updated result & fixed further more(distinct_stats was fall back to normal plan by exception making struct OI)


Bugs: HIVE-9397
    https://issues.apache.org/jira/browse/HIVE-9397


Repository: hive-git


Description
-------

These queries produce an error :

{code:sql}
DROP TABLE IF EXISTS foo;

CREATE TABLE foo (id int) STORED AS ORC;

INSERT INTO TABLE foo VALUES (1);
INSERT INTO TABLE foo VALUES (2);
INSERT INTO TABLE foo VALUES (3);
INSERT INTO TABLE foo VALUES (4);
INSERT INTO TABLE foo VALUES (5);

SELECT max(id) FROM foo;

ANALYZE TABLE foo COMPUTE STATISTICS FOR COLUMNS id;

SELECT max(id) FROM foo;
{code}

The last query throws {{org.apache.hive.service.cli.HiveSQLException}}
{noformat}
0: jdbc:hive2://nc-h04:10000/casino> SELECT max(id) FROM foo;
+-------------+--+
|     _c0     |
+-------------+--+
org.apache.hive.service.cli.HiveSQLException: java.lang.ClassCastException
0: jdbc:hive2://nc-h04:10000/casino>
{noformat}


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 6961d7f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java d1118f1 
  ql/src/test/results/clientpositive/metadata_only_queries.q.out 90c76ed 
  ql/src/test/results/clientpositive/metadata_only_queries_with_filters.q.out 5be958f 
  ql/src/test/results/clientpositive/spark/metadata_only_queries.q.out 9d6a404 
  ql/src/test/results/clientpositive/spark/metadata_only_queries_with_filters.q.out 5be958f 
  ql/src/test/results/clientpositive/tez/metadata_only_queries.q.out 8c0bccb 

Diff: https://reviews.apache.org/r/30549/diff/


Testing
-------


Thanks,

Navis Ryu