You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2009/01/02 18:14:05 UTC
[jira] Created: (CAMEL-1213) camel-jms consumer does not set camel
message id based on JMS message id if the next node is not JMS based
camel-jms consumer does not set camel message id based on JMS message id if the next node is not JMS based
----------------------------------------------------------------------------------------------------------
Key: CAMEL-1213
URL: https://issues.apache.org/activemq/browse/CAMEL-1213
Project: Apache Camel
Issue Type: Bug
Components: camel-jms
Affects Versions: 1.5.0
Reporter: Claus Ibsen
Fix For: 1.5.1, 2.0.0
The code in org.apache.camel.component.jms.copyFrom looks odd
I think the ! should be removed
BEFORE
{code}
if (!copyMessageId) {
setMessageId(that.getMessageId());
}
{code}
AFTER
{code}
if (copyMessageId) {
setMessageId(that.getMessageId());
}
{code}
I will add a unit test (JmsToFileMessageIdTest) based on end user having some trouble with it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-1213) camel-jms consumer does not set camel
message id based on JMS message id if the next node is not JMS based
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-1213.
--------------------------------
Resolution: Fixed
trunk: r731836
1.x: r731839
> camel-jms consumer does not set camel message id based on JMS message id if the next node is not JMS based
> ----------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1213
> URL: https://issues.apache.org/activemq/browse/CAMEL-1213
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.5.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 1.5.1, 2.0.0
>
> Attachments: CAMEL-1213.patch
>
>
> The code in org.apache.camel.component.jms.copyFrom looks odd
> I think the ! should be removed
> BEFORE
> {code}
> if (!copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> AFTER
> {code}
> if (copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> I will add a unit test (JmsToFileMessageIdTest) based on end user having some trouble with it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1213) camel-jms consumer does not set
camel message id based on JMS message id if the next node is not JMS based
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48476#action_48476 ]
James Strachan commented on CAMEL-1213:
---------------------------------------
agreed! :)
> camel-jms consumer does not set camel message id based on JMS message id if the next node is not JMS based
> ----------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1213
> URL: https://issues.apache.org/activemq/browse/CAMEL-1213
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.5.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 1.5.1, 2.0.0
>
> Attachments: CAMEL-1213.patch
>
>
> The code in org.apache.camel.component.jms.copyFrom looks odd
> I think the ! should be removed
> BEFORE
> {code}
> if (!copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> AFTER
> {code}
> if (copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> I will add a unit test (JmsToFileMessageIdTest) based on end user having some trouble with it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-1213) camel-jms consumer does not set camel
message id based on JMS message id if the next node is not JMS based
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-1213:
----------------------------------
Assignee: Claus Ibsen
> camel-jms consumer does not set camel message id based on JMS message id if the next node is not JMS based
> ----------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1213
> URL: https://issues.apache.org/activemq/browse/CAMEL-1213
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.5.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 1.5.1, 2.0.0
>
> Attachments: CAMEL-1213.patch
>
>
> The code in org.apache.camel.component.jms.copyFrom looks odd
> I think the ! should be removed
> BEFORE
> {code}
> if (!copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> AFTER
> {code}
> if (copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> I will add a unit test (JmsToFileMessageIdTest) based on end user having some trouble with it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1213) camel-jms consumer does not set
camel message id based on JMS message id if the next node is not JMS based
Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48427#action_48427 ]
Jonathan Anstey commented on CAMEL-1213:
----------------------------------------
Claus,
The fix makes sense to me. I think the ! was just a typo when JmsMessage was originally created.
> camel-jms consumer does not set camel message id based on JMS message id if the next node is not JMS based
> ----------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1213
> URL: https://issues.apache.org/activemq/browse/CAMEL-1213
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.5.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 1.5.1, 2.0.0
>
> Attachments: CAMEL-1213.patch
>
>
> The code in org.apache.camel.component.jms.copyFrom looks odd
> I think the ! should be removed
> BEFORE
> {code}
> if (!copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> AFTER
> {code}
> if (copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> I will add a unit test (JmsToFileMessageIdTest) based on end user having some trouble with it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1213) camel-jms consumer does not set camel
message id based on JMS message id if the next node is not JMS based
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-1213:
-------------------------------
Attachment: CAMEL-1213.patch
Fellow riders, please review the patch.
> camel-jms consumer does not set camel message id based on JMS message id if the next node is not JMS based
> ----------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1213
> URL: https://issues.apache.org/activemq/browse/CAMEL-1213
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.5.0
> Reporter: Claus Ibsen
> Fix For: 1.5.1, 2.0.0
>
> Attachments: CAMEL-1213.patch
>
>
> The code in org.apache.camel.component.jms.copyFrom looks odd
> I think the ! should be removed
> BEFORE
> {code}
> if (!copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> AFTER
> {code}
> if (copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> I will add a unit test (JmsToFileMessageIdTest) based on end user having some trouble with it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1213) camel-jms consumer does not set
camel message id based on JMS message id if the next node is not JMS based
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48477#action_48477 ]
James Strachan commented on CAMEL-1213:
---------------------------------------
bad James! :)
> camel-jms consumer does not set camel message id based on JMS message id if the next node is not JMS based
> ----------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-1213
> URL: https://issues.apache.org/activemq/browse/CAMEL-1213
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-jms
> Affects Versions: 1.5.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 1.5.1, 2.0.0
>
> Attachments: CAMEL-1213.patch
>
>
> The code in org.apache.camel.component.jms.copyFrom looks odd
> I think the ! should be removed
> BEFORE
> {code}
> if (!copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> AFTER
> {code}
> if (copyMessageId) {
> setMessageId(that.getMessageId());
> }
> {code}
> I will add a unit test (JmsToFileMessageIdTest) based on end user having some trouble with it
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.