You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2011/06/04 03:18:47 UTC

[jira] [Created] (OWB-581) Decorator interface check needs configurable exclusions

Decorator interface check needs configurable exclusions
-------------------------------------------------------

                 Key: OWB-581
                 URL: https://issues.apache.org/jira/browse/OWB-581
             Project: OpenWebBeans
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.1.1
            Reporter: David Jencks
            Assignee: David Jencks


Aries proxy weaving code adds an interface to every class and so does Cobertura for code coverage.  This breaks the implemented interface checks for decorators.    Gurkan suggested using the spi package but I don't see a reasonable way to do that.  I've implemented a solution using a configuration property.  If not present, it just excludes Serializable as done now.

There are a couple places where only one method is expected in a OWB object but weaving may add more.  I've fixed these places too to find the desired method by name.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (OWB-581) Decorator interface check needs configurable exclusions

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks resolved OWB-581.
------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.1

rev 1131302.  This works, if you have a better idea comment or reopen or implement.

> Decorator interface check needs configurable exclusions
> -------------------------------------------------------
>
>                 Key: OWB-581
>                 URL: https://issues.apache.org/jira/browse/OWB-581
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.1
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 1.1.1
>
>
> Aries proxy weaving code adds an interface to every class and so does Cobertura for code coverage.  This breaks the implemented interface checks for decorators.    Gurkan suggested using the spi package but I don't see a reasonable way to do that.  I've implemented a solution using a configuration property.  If not present, it just excludes Serializable as done now.
> There are a couple places where only one method is expected in a OWB object but weaving may add more.  I've fixed these places too to find the desired method by name.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OWB-581) Decorator interface check needs configurable exclusions

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OWB-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044628#comment-13044628 ] 

David Jencks commented on OWB-581:
----------------------------------

The added interface causes tons more problems.  I've excluded it whereever I've detected a problem in rev 1132498.

I've asked the aries folks if it would be possible to mark this interface synthetic (or, better, remove it entirely) in which case we could just exclude synthetic interfaces here in OWB.  No response yet.  Not sure what this would do to or for cobertura.

> Decorator interface check needs configurable exclusions
> -------------------------------------------------------
>
>                 Key: OWB-581
>                 URL: https://issues.apache.org/jira/browse/OWB-581
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.1
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 1.1.1
>
>
> Aries proxy weaving code adds an interface to every class and so does Cobertura for code coverage.  This breaks the implemented interface checks for decorators.    Gurkan suggested using the spi package but I don't see a reasonable way to do that.  I've implemented a solution using a configuration property.  If not present, it just excludes Serializable as done now.
> There are a couple places where only one method is expected in a OWB object but weaving may add more.  I've fixed these places too to find the desired method by name.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira