You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "jeremy-degroot (via GitHub)" <gi...@apache.org> on 2023/03/30 14:53:04 UTC

[GitHub] [flink] jeremy-degroot opened a new pull request, #22309: FLINK-29398 [Kafka Source] Provide rack ID to Kafka Source to take advantage of Rack Awareness

jeremy-degroot opened a new pull request, #22309:
URL: https://github.com/apache/flink/pull/22309

   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   This PR adds a new method to KafkaSourceBuilder that sets the `client.id` config for the KafkaSource to the value returned by the provided Supplier. It needs to be a Supplier because it needs to run on the TaskManager, and can't be determined at Job submit time like other configs.
   
   ## Brief change log
   
     - *Add setRackId to KafkaSourceBuilder*
     - *Plumb rackId into KafkaPartitionSplitReader*
     - *Add rack id tests*
     -  *Document RackId feature*
   
   
   ## Verifying this change
     - *Added tests for the KafkaSplitReader that verify behaviors for null rackId Supplier, null and empty return values, and provided values.*
     - *Manually verified the change by running a 3-node cluster that covered two "racks" (AWS Availability Zones) against an Amazon MSK cluster.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs/Javadocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] MartijnVisser commented on pull request #22309: FLINK-29398 [Kafka Source] Provide rack ID to Kafka Source to take advantage of Rack Awareness

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22309:
URL: https://github.com/apache/flink/pull/22309#issuecomment-1490467770

   > @MartijnVisser just to be clear, you're recommending I close this PR, and implement my change against https://github.com/apache/flink-connector-kafka/pulls?
   
   Yes, given that we won't merge this anymore into `master` since the code will be removed from that branch shortly. All development for the Flink Kafka connector will continue in that dedicated repo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] jeremy-degroot commented on pull request #22309: FLINK-29398 [Kafka Source] Provide rack ID to Kafka Source to take advantage of Rack Awareness

Posted by "jeremy-degroot (via GitHub)" <gi...@apache.org>.
jeremy-degroot commented on PR #22309:
URL: https://github.com/apache/flink/pull/22309#issuecomment-1490659748

   PR moved to https://github.com/apache/flink-connector-kafka/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] jeremy-degroot commented on pull request #22309: FLINK-29398 [Kafka Source] Provide rack ID to Kafka Source to take advantage of Rack Awareness

Posted by "jeremy-degroot (via GitHub)" <gi...@apache.org>.
jeremy-degroot commented on PR #22309:
URL: https://github.com/apache/flink/pull/22309#issuecomment-1490464873

   @MartijnVisser just to be clear, you're recommending I close this PR, and implement my change against https://github.com/apache/flink-connector-kafka/pulls?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #22309: FLINK-29398 [Kafka Source] Provide rack ID to Kafka Source to take advantage of Rack Awareness

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22309:
URL: https://github.com/apache/flink/pull/22309#issuecomment-1490466273

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "879e0a66a7fda5c5a50c38568945f315340217f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "879e0a66a7fda5c5a50c38568945f315340217f0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 879e0a66a7fda5c5a50c38568945f315340217f0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] MartijnVisser commented on pull request #22309: FLINK-29398 [Kafka Source] Provide rack ID to Kafka Source to take advantage of Rack Awareness

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22309:
URL: https://github.com/apache/flink/pull/22309#issuecomment-1490451791

   @jeremy-degroot Thanks for the PR, it will be good to move this to apache/flink-connector-kafkak:main - See https://lists.apache.org/thread/s85o6ym545tbl2cwv228wxbhyynp6g14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] jeremy-degroot closed pull request #22309: FLINK-29398 [Kafka Source] Provide rack ID to Kafka Source to take advantage of Rack Awareness

Posted by "jeremy-degroot (via GitHub)" <gi...@apache.org>.
jeremy-degroot closed pull request #22309: FLINK-29398 [Kafka Source] Provide rack ID to Kafka Source to take advantage of Rack Awareness
URL: https://github.com/apache/flink/pull/22309


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org