You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/28 15:16:37 UTC

[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #2968: fix `RowWriter` index out of bounds error

comphead commented on code in PR #2968:
URL: https://github.com/apache/arrow-datafusion/pull/2968#discussion_r932376056


##########
datafusion/row/src/writer.rs:
##########
@@ -269,29 +269,29 @@ impl RowWriter {
 
 /// Stitch attributes of tuple in `batch` at `row_idx` and returns the tuple width
 pub fn write_row(
-    row: &mut RowWriter,
+    row_writer: &mut RowWriter,

Review Comment:
   I thought its better naming, because when reading the code I supposed the `row`  is either incoming row or row buffer, both  are not correct. row_writer better reflects the object imho.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org