You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/06/06 16:49:13 UTC

[GitHub] [incubator-iceberg] danielcweeks commented on a change in pull request #206: Add option to load column stats with data files.

danielcweeks commented on a change in pull request #206: Add option to load column stats with data files.
URL: https://github.com/apache/incubator-iceberg/pull/206#discussion_r291274115
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/GenericDataFile.java
 ##########
 @@ -165,7 +165,7 @@ public GenericDataFile(org.apache.avro.Schema avroSchema) {
    *
    * @param toCopy a generic data file to copy.
    */
-  private GenericDataFile(GenericDataFile toCopy) {
+  private GenericDataFile(GenericDataFile toCopy, boolean fullCopy) {
 
 Review comment:
   Nit: Javadoc @params are now inconsistent.  I'd be fine with either removing the exiting comment or adding the new one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org