You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by westover <gi...@git.apache.org> on 2017/09/27 06:38:04 UTC
[GitHub] avro pull request #251: Python 2/3 unification a new approach (backport avro...
GitHub user westover opened a pull request:
https://github.com/apache/avro/pull/251
Python 2/3 unification a new approach (backport avro-python3)
Like #234 and #133 I am also interested in unifying python2/3 support so I have taken the opposite approach. Take python3 implementation and back port it to python2. This now supports python2 and 3 which is verifiable with Tox. I have added support for tox which is optional but viable. I have revived the lowercase method ```parse``` in schema.py to bring full backwards compatibility
So now recommended testing path for https://cwiki.apache.org/confluence/display/AVRO/How+To+Contribute is
```
cd lang/py3
tox
```
It would be advisable to follow up this pull with the creation of a symlink to lang/py so both packages can be created.
I hope this can help others like it will help me.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/earthmine/avro master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #251
----
commit f6bb3eb859a9da749fe097568f86403836f335b1
Author: James Westover <ja...@icloud.com>
Date: 2017-09-15T17:53:29Z
Lowercase parse function to improve compatibility
commit 952d52b4d9940169588bdc39dd0b9a98319842a1
Author: James Westover <ja...@here.com>
Date: 2017-09-27T03:48:06Z
all tests passing python2
commit 63078071a36bd34a9115874e98c0bc9c6ab6a9ed
Author: James Westover <ja...@here.com>
Date: 2017-09-27T04:55:51Z
tests run but fail under py27 all tests pass py36
commit 6e3f2512030786eed334feabf97bb97520ae39ee
Author: James Westover <ja...@here.com>
Date: 2017-09-27T04:58:06Z
Working setup.py for py2
commit f3983cc700a8e554442423190f8b0b9e53be6d3f
Author: James Westover <ja...@here.com>
Date: 2017-09-27T04:58:34Z
adding tox to automate multiversion testing
commit 39ff3fb4c6db2a96eafed322bdefd6b4e728052c
Author: James Westover <ja...@here.com>
Date: 2017-09-27T04:58:49Z
ignoring testing artifacts
commit 4751fd4a5e455cdfc0b6f6225e66bca87aa6df0c
Author: James Westover <ja...@here.com>
Date: 2017-09-27T05:59:57Z
Working datafile tests
commit f6dc4c47a7ef1081f43012303926eed17d6a2786
Author: James Westover <ja...@here.com>
Date: 2017-09-27T06:22:24Z
Making these 2-3 compliant
commit e0f284da1a199a91d30c65b72ac6c4a202a488d7
Author: James Westover <ja...@here.com>
Date: 2017-09-27T06:22:38Z
Adding a requirement for backports.tempfile
commit 82fd018b2014101db67537a2d0e610b64f2a7107
Author: James Westover <ja...@here.com>
Date: 2017-09-27T06:23:00Z
making the tests work for both 2 and 3
commit 151ea165cbaa8cb0b53c090b1b0fb00660fae9db
Author: James Westover <ja...@here.com>
Date: 2017-09-27T06:25:47Z
Adding a dependancy on backports.tempfile for the tests
commit a06ccda4f0e45f2d33ffe20fd96ed2e069d192c6
Author: James Westover <ja...@here.com>
Date: 2017-09-27T06:35:47Z
Adding in Parse so both parse and Parse are available
----
---