You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/10/16 09:31:26 UTC
[Bug 54011] New: Code generation error in jstl tagPlugin "Out" when
has "escapeXml" on the tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
Priority: P2
Bug ID: 54011
Assignee: dev@tomcat.apache.org
Summary: Code generation error in jstl tagPlugin "Out" when has
"escapeXml" on the tag
Severity: normal
Classification: Unclassified
Reporter: xshao@ebay.com
Hardware: PC
Status: NEW
Version: trunk
Component: Jasper
Product: Tomcat 7
Created attachment 29482
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29482&action=edit
Patch for org.apache.jasper.tagplugins.jstl.core.Out.java
When setting up org.apache.jasper.tagplugins.jstl.core.Out as a tagplugin and
trying to make code generation for the following code,
<c:out escapeXml="false" value="test"/>
It will generate an error.
It has a typo in it
if(hasEscapeXml){
ctxt.generateJavaSource(strEscapeXmlName + " = Boolean.parseBoolean((");
ctxt.generateAttribute("default");
ctxt.generateJavaSource(").toString());");
}
The attribute name should be "escapeXml".
Even change the right name, it occurs an error because of
"(false).toString()".
Attached two patchs for this bug fix and code simplified.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54011] Code generation error in jstl tagPlugin "Out" when has
"escapeXml" on the tagPlugin
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
--- Comment #4 from Konstantin Kolinko <kn...@gmail.com> ---
See bug 54144 for review of r1401816 and other missing features of tagplugin
implementation of the <c:out> tag.
Essentially, this patch has to be reverted, as it broke a feature of the
<c:out> tag that the tag body is used as the default if none is specified.
Those were the following lines:
- ctxt.generateJavaSource(" }else{");
- ctxt.generateBody();
- ctxt.generateJavaSource(" }");
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54011] Code generation error in jstl tagPlugin "Out" when has
"escapeXml" on the tag
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
Sheldon Shao <xs...@ebay.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29482|0 |1
is obsolete| |
--- Comment #2 from Sheldon Shao <xs...@ebay.com> ---
Created attachment 29484
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29484&action=edit
Patch for org.apache.jasper.tagplugins.jstl.core.Out.java
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54011] Code generation error in jstl tagPlugin "Out" when has
"escapeXml" on the tagPlugin
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
--- Comment #5 from Mark Thomas <ma...@apache.org> ---
I've fixed using body as the default issue in trunk and 7.0.x.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54011] Code generation error in jstl tagPlugin "Out" when has
"escapeXml" on the tagPlugin
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
Sheldon Shao <xs...@ebay.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Code generation error in |Code generation error in
|jstl tagPlugin "Out" when |jstl tagPlugin "Out" when
|has "escapeXml" on the tag |has "escapeXml" on the
| |tagPlugin
OS| |All
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54011] Code generation error in jstl tagPlugin "Out" when has
"escapeXml" on the tag
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
--- Comment #1 from Sheldon Shao <xs...@ebay.com> ---
Created attachment 29483
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29483&action=edit
Patch for org.apache.jasper.tagplugins.jstl.Util.java
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54011] Code generation error in jstl tagPlugin "Out" when has
"escapeXml" on the tagPlugin
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54011
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Many thanks for the patches. I modified the clean-up slightly and added some
test cases for trunk.
The fix was applied to trunk and 7.0.x and will be included in 7.0.33 onwards.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org