You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/05/24 17:15:11 UTC
[kudu-CR] docs: clarify that max cell size applies to uncompressed size
Hello Ambreen Kazi, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6977
to review the following change.
Change subject: docs: clarify that max cell size applies to uncompressed size
......................................................................
docs: clarify that max cell size applies to uncompressed size
Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
---
M docs/schema_design.adoc
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/6977/1
--
To view, visit http://gerrit.cloudera.org:8080/6977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: clarify that max cell size applies to uncompressed size
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6977
to look at the new patch set (#3).
Change subject: docs: clarify that max cell size applies to uncompressed size
......................................................................
docs: clarify that max cell size applies to uncompressed size
Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
---
M docs/known_issues.adoc
M docs/schema_design.adoc
2 files changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/6977/3
--
To view, visit http://gerrit.cloudera.org:8080/6977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: clarify that max cell size applies to uncompressed size
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: docs: clarify that max cell size applies to uncompressed size
......................................................................
docs: clarify that max cell size applies to uncompressed size
Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
Reviewed-on: http://gerrit.cloudera.org:8080/6977
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M docs/known_issues.adoc
M docs/schema_design.adoc
2 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: clarify that max cell size applies to uncompressed size
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: docs: clarify that max cell size applies to uncompressed size
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: clarify that max cell size applies to uncompressed size
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: docs: clarify that max cell size applies to uncompressed size
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6977/2/docs/known_issues.adoc
File docs/known_issues.adoc:
PS2, Line 68: ncodingn
encoding
--
To view, visit http://gerrit.cloudera.org:8080/6977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: clarify that max cell size applies to uncompressed size
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: docs: clarify that max cell size applies to uncompressed size
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6977/2/docs/known_issues.adoc
File docs/known_issues.adoc:
PS2, Line 68: ncodingn
> encoding
Done
--
To view, visit http://gerrit.cloudera.org:8080/6977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: clarify that max cell size applies to uncompressed size
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has uploaded a new patch set (#2).
Change subject: docs: clarify that max cell size applies to uncompressed size
......................................................................
docs: clarify that max cell size applies to uncompressed size
Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
---
M docs/known_issues.adoc
M docs/schema_design.adoc
2 files changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/6977/2
--
To view, visit http://gerrit.cloudera.org:8080/6977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6522fb625138191b0ff8ec295245c27d83a5c532
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>