[GitHub] [trafficserver] vmamidi commented on issue #7471: ATS 9.0.1: current_server_connections, current_server_transactions metrics broken

[GitBox <gi...@apache.org>]

vmamidi commented on issue #7471:
URL: https://github.com/apache/trafficserver/issues/7471#issuecomment-801315273


   > This is just a possibility, but I thought it's worth noting.
   > 
   > Seems like removal of sessions from the pool depends on inactivity timeout of sessions (or underlying netvcs). If the timeout didn't happen on a session, the session would stay in the pool forever, unless other controls (e.g. `per_server.connection.max`) kick in.
   > 
   > This line below is suspecious, because it relies on the inactive timeout value currently set. If inactivity timeout is cancelled or set to 0, it does nothing. I think we need to read the original value from the config.
   
   isn't that a configuration bug? Why would you set inactive timeout to zero?
   > https://github.com/apache/trafficserver/blob/d4fc16f64d3104d3682d496e47f2a53511fa77e0/proxy/http/HttpSessionManager.cc#L215
   > 
   > https://github.com/apache/trafficserver/blob/d4fc16f64d3104d3682d496e47f2a53511fa77e0/iocore/net/P_UnixNetVConnection.h#L348-L352
   > 
   > https://github.com/apache/trafficserver/blob/d4fc16f64d3104d3682d496e47f2a53511fa77e0/iocore/net/UnixNetVConnection.cc#L1354-L1360
   > 
   > https://github.com/apache/trafficserver/blob/d4fc16f64d3104d3682d496e47f2a53511fa77e0/iocore/net/P_UnixNetVConnection.h#L362-L368
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org