You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/13 15:21:15 UTC
[GitHub] [kafka] chia7712 opened a new pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…
chia7712 opened a new pull request #9423:
URL: https://github.com/apache/kafka/pull/9423
The following actions results in this issue.
1. handle_1 gets the current log
2. ReplicaAlterLogDirsThread replaces current log by future log
3. handle_1 set the new hw to “current” log but the log is actually invalid
The solution is that the action 1 and 3 must be executed within same read lock of leaderIsrUpdateLock to avoid adding new hw to invalid log (which is replaced by ReplicaAlterLogDirsThread)
**Test Plan**
Relying on ```PlaintextAdminIntegrationTest.testAlterReplicaLogDirs```. I have looped the test with this patch 100 times. all pass
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9423:
URL: https://github.com/apache/kafka/pull/9423#issuecomment-734131582
@junrao Could you take a look? There is no report about this bug in production but we can reproduce the bug by ```PlaintextAdminIntegrationTest.testAlterReplicaLogDirs```. It happens infrequently but it is dangerous as it can misorder the HW.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9423:
URL: https://github.com/apache/kafka/pull/9423#issuecomment-736388571
```kafka.api.TransactionsTest.testBumpTransactionalEpoch``` is traced by #9291
```org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta``` and ```SourceConnectorsIntegrationTest``` are known flaky
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9423:
URL: https://github.com/apache/kafka/pull/9423#issuecomment-708252424
```
kafka.api.PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords
```
pass on my local.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9423:
URL: https://github.com/apache/kafka/pull/9423#issuecomment-708886001
@hachikuji @lbradstreet Could you take a look? ```maybeIncrementLeaderHW``` was called with holding lock (https://github.com/apache/kafka/commit/f3ded39a0556f9e43a66b238c89c6a60f3ef33df#diff-16590fdbe6661105c6faa87d68e39a553e66b34ee0a6d0b14a48d02e273bab4fL676) and https://github.com/apache/kafka/commit/f3ded39a0556f9e43a66b238c89c6a60f3ef33df changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9423:
URL: https://github.com/apache/kafka/pull/9423#issuecomment-736593865
@junrao I will merge it to trunk tomorrow if there is no objection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9423:
URL: https://github.com/apache/kafka/pull/9423#issuecomment-736222765
> Are test failures related to this PR?
They are unrelated error. Will rebase PR to trigger QA again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9423:
URL: https://github.com/apache/kafka/pull/9423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org