You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Raju Bairishetti <ra...@gmail.com> on 2015/01/29 17:45:47 UTC
Re: Review Request 30390: LENS-19: rovide an option to list all
resources added in a session
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30390/
-----------------------------------------------------------
(Updated Jan. 29, 2015, 4:45 p.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
Addressed reviewer comments
Summary (updated)
-----------------
LENS-19: rovide an option to list all resources added in a session
Bugs: LENS-19
https://issues.apache.org/jira/browse/LENS-19
Repository: lens
Description
-------
Provide an option to list all resources added in a session
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java f1b4ea7
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java c8d0383
lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6
lens-client/src/main/java/org/apache/lens/client/LensConnection.java bc07e68
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java aa65e15
lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java b3cf2c3
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 109b36d
src/site/apt/user/cli.apt 270265c
Diff: https://reviews.apache.org/r/30390/diff/
Testing
-------
Added a unit test in TestLensConnectionCliCommands and testing th behavior in TestSessionResource
Thanks,
Raju Bairishetti
Re: Review Request 30390: LENS-19: Provide an option to list all
resources added in a session
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30390/#review70318
-----------------------------------------------------------
Changes look good. Can you update the test result?
- Amareshwari Sriramadasu
On Jan. 30, 2015, 3 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30390/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 3 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-19
> https://issues.apache.org/jira/browse/LENS-19
>
>
> Repository: lens
>
>
> Description
> -------
>
> Provide an option to list all resources added in a session
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java f1b4ea7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java c8d0383
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java bc07e68
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java aa65e15
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java b3cf2c3
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 109b36d
> src/site/apt/user/cli.apt 270265c
>
> Diff: https://reviews.apache.org/r/30390/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestLensConnectionCliCommands and testing th behavior in TestSessionResource
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30390: LENS-19: Provide an option to list all
resources added in a session
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30390/#review70503
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
<https://reviews.apache.org/r/30390/#comment115718>
This should be on server side. CLI check shouldnt be required.
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
<https://reviews.apache.org/r/30390/#comment115719>
Return as "No resources found"
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
<https://reviews.apache.org/r/30390/#comment115720>
Shouldn't be on client side
lens-server/src/main/java/org/apache/lens/server/LensService.java
<https://reviews.apache.org/r/30390/#comment115721>
unused import?
- Amareshwari Sriramadasu
On Jan. 31, 2015, 4:36 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30390/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 4:36 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-19
> https://issues.apache.org/jira/browse/LENS-19
>
>
> Repository: lens
>
>
> Description
> -------
>
> Provide an option to list all resources added in a session
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java f1b4ea7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java c8d0383
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java bc07e68
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java aa65e15
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java b3cf2c3
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 109b36d
> src/site/apt/user/cli.apt 270265c
>
> Diff: https://reviews.apache.org/r/30390/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestLensConnectionCliCommands and testing th behavior in TestSessionResource
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30390: LENS-19: Provide an option to list all
resources added in a session
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30390/#review70507
-----------------------------------------------------------
Ship it!
Looks fine. Please update full test result.
- Amareshwari Sriramadasu
On Jan. 31, 2015, 2:59 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30390/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 2:59 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-19
> https://issues.apache.org/jira/browse/LENS-19
>
>
> Repository: lens
>
>
> Description
> -------
>
> Provide an option to list all resources added in a session
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java f1b4ea7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java c8d0383
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java bc07e68
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java aa65e15
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java b3cf2c3
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 109b36d
> src/site/apt/user/cli.apt 270265c
>
> Diff: https://reviews.apache.org/r/30390/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestLensConnectionCliCommands and testing th behavior in TestSessionResource
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30390: LENS-19: Provide an option to list all
resources added in a session
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30390/
-----------------------------------------------------------
(Updated Jan. 31, 2015, 2:59 p.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
throw badrequst exception from server side if it is invalid
Bugs: LENS-19
https://issues.apache.org/jira/browse/LENS-19
Repository: lens
Description
-------
Provide an option to list all resources added in a session
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java f1b4ea7
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java c8d0383
lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6
lens-client/src/main/java/org/apache/lens/client/LensConnection.java bc07e68
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java aa65e15
lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java b3cf2c3
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 109b36d
src/site/apt/user/cli.apt 270265c
Diff: https://reviews.apache.org/r/30390/diff/
Testing
-------
Added a unit test in TestLensConnectionCliCommands and testing th behavior in TestSessionResource
Thanks,
Raju Bairishetti
Re: Review Request 30390: LENS-19: Provide an option to list all
resources added in a session
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30390/
-----------------------------------------------------------
(Updated Jan. 31, 2015, 4:36 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-19
https://issues.apache.org/jira/browse/LENS-19
Repository: lens
Description
-------
Provide an option to list all resources added in a session
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java f1b4ea7
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java c8d0383
lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6
lens-client/src/main/java/org/apache/lens/client/LensConnection.java bc07e68
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java aa65e15
lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java b3cf2c3
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 109b36d
src/site/apt/user/cli.apt 270265c
Diff: https://reviews.apache.org/r/30390/diff/
Testing
-------
Added a unit test in TestLensConnectionCliCommands and testing th behavior in TestSessionResource
Thanks,
Raju Bairishetti
Re: Review Request 30390: LENS-19: Provide an option to list all
resources added in a session
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30390/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 11:34 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
throw BadRequestException if user specify wrong source type and added test for the same
Bugs: LENS-19
https://issues.apache.org/jira/browse/LENS-19
Repository: lens
Description
-------
Provide an option to list all resources added in a session
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java f1b4ea7
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java c8d0383
lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6
lens-client/src/main/java/org/apache/lens/client/LensConnection.java bc07e68
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java aa65e15
lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java b3cf2c3
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 109b36d
src/site/apt/user/cli.apt 270265c
Diff: https://reviews.apache.org/r/30390/diff/
Testing
-------
Added a unit test in TestLensConnectionCliCommands and testing th behavior in TestSessionResource
Thanks,
Raju Bairishetti
Re: Review Request 30390: LENS-19: Provide an option to list all
resources added in a session
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30390/#review70319
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Jan. 30, 2015, 3 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30390/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 3 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-19
> https://issues.apache.org/jira/browse/LENS-19
>
>
> Repository: lens
>
>
> Description
> -------
>
> Provide an option to list all resources added in a session
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java f1b4ea7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java c8d0383
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java bc07e68
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java aa65e15
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java b3cf2c3
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 109b36d
> src/site/apt/user/cli.apt 270265c
>
> Diff: https://reviews.apache.org/r/30390/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestLensConnectionCliCommands and testing th behavior in TestSessionResource
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30390: LENS-19: Provide an option to list all
resources added in a session
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30390/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 3 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Summary (updated)
-----------------
LENS-19: Provide an option to list all resources added in a session
Bugs: LENS-19
https://issues.apache.org/jira/browse/LENS-19
Repository: lens
Description
-------
Provide an option to list all resources added in a session
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java f1b4ea7
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java c8d0383
lens-client/src/main/java/org/apache/lens/client/LensClient.java 85329d6
lens-client/src/main/java/org/apache/lens/client/LensConnection.java bc07e68
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java aa65e15
lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java b3cf2c3
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 109b36d
src/site/apt/user/cli.apt 270265c
Diff: https://reviews.apache.org/r/30390/diff/
Testing
-------
Added a unit test in TestLensConnectionCliCommands and testing th behavior in TestSessionResource
Thanks,
Raju Bairishetti