[GitHub] [ozone] szetszwo commented on a diff in pull request #4531: HDDS-8292. Inconsistent key name handling for FSO bucket files.

["szetszwo (via GitHub)" <gi...@apache.org>]

szetszwo commented on code in PR #4531:
URL: https://github.com/apache/ozone/pull/4531#discussion_r1198505613


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDirectoryInfo.java:
##########
@@ -266,4 +267,26 @@ public OmDirectoryInfo copyObject() {
 
     return builder.build();
   }
+
+  /**
+   * Return a new copy of the object.
+   */
+  @Override
+  public Object clone() throws CloneNotSupportedException {

Review Comment:
   > Here we are reading from cache which is of generic type and for this reason we cannot use CopyObject. ...
   
   @ashishkumar50 , Could you show me the code?  I really think that we should not have both `copyObject()` and `clone()`.  Let me see if there is a way to get ride of `clone()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org