You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "BjornPrime (via GitHub)" <gi...@apache.org> on 2023/07/05 18:22:23 UTC

[GitHub] [beam] BjornPrime opened a new pull request, #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

BjornPrime opened a new pull request, #27364:
URL: https://github.com/apache/beam/pull/27364

   fixes #27325. 
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] BjornPrime commented on pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "BjornPrime (via GitHub)" <gi...@apache.org>.
BjornPrime commented on PR #27364:
URL: https://github.com/apache/beam/pull/27364#issuecomment-1624009359

   Run Python 3.11 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] BjornPrime closed pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "BjornPrime (via GitHub)" <gi...@apache.org>.
BjornPrime closed pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses
URL: https://github.com/apache/beam/pull/27364


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] BjornPrime commented on pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "BjornPrime (via GitHub)" <gi...@apache.org>.
BjornPrime commented on PR #27364:
URL: https://github.com/apache/beam/pull/27364#issuecomment-1623755673

   Run Python 3.11 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] liferoad commented on a diff in pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #27364:
URL: https://github.com/apache/beam/pull/27364#discussion_r1253574264


##########
sdks/python/apache_beam/io/gcp/gcsio.py:
##########
@@ -203,6 +203,10 @@ def delete_batch(self, paths):
     Args:
       paths: List of GCS file path patterns in the form gs://<bucket>/<name>,
              not to exceed MAX_BATCH_OPERATION_SIZE in length.
+
+    Returns: List of tuples of (path, exception) in the same order as the

Review Comment:
   This change breaks the `delete_batch` return behavior. It is probably better to create a new API like `delete_batch_with_response`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] BjornPrime commented on pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "BjornPrime (via GitHub)" <gi...@apache.org>.
BjornPrime commented on PR #27364:
URL: https://github.com/apache/beam/pull/27364#issuecomment-1632919458

   Changes incorporated into new GCSIO client swap PR #27471 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] BjornPrime commented on pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "BjornPrime (via GitHub)" <gi...@apache.org>.
BjornPrime commented on PR #27364:
URL: https://github.com/apache/beam/pull/27364#issuecomment-1625294119

   Run Python 3.11 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] BjornPrime commented on pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "BjornPrime (via GitHub)" <gi...@apache.org>.
BjornPrime commented on PR #27364:
URL: https://github.com/apache/beam/pull/27364#issuecomment-1625496233

   Run Python 3.11 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] BjornPrime commented on pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "BjornPrime (via GitHub)" <gi...@apache.org>.
BjornPrime commented on PR #27364:
URL: https://github.com/apache/beam/pull/27364#issuecomment-1622263454

   Run Python 3.11 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] BjornPrime commented on pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "BjornPrime (via GitHub)" <gi...@apache.org>.
BjornPrime commented on PR #27364:
URL: https://github.com/apache/beam/pull/27364#issuecomment-1624412009

   Run Python 3.11 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27364:
URL: https://github.com/apache/beam/pull/27364#issuecomment-1622363852

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @liferoad for label python.
   R: @ahmedabu98 for label io.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27364:
URL: https://github.com/apache/beam/pull/27364#issuecomment-1622284784

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#27364](https://app.codecov.io/gh/apache/beam/pull/27364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (116b23b) into [master](https://app.codecov.io/gh/apache/beam/commit/1842dd2f07aee9485c37333882c2f9d1e80f880c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1842dd2) will **increase** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #27364   +/-   ##
   =======================================
     Coverage   71.23%   71.24%           
   =======================================
     Files         854      854           
     Lines      103713   103738   +25     
   =======================================
   + Hits        73885    73906   +21     
   - Misses      28280    28284    +4     
     Partials     1548     1548           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `80.58% <0.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/27364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/io/gcp/gcsio.py](https://app.codecov.io/gh/apache/beam/pull/27364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2lvLnB5) | `66.07% <0.00%> (-0.59%)` | :arrow_down: |
   
   ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27364/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] BjornPrime commented on a diff in pull request #27364: [DO NOT MERGE; currently testing] standardizing GCSIO batch responses

Posted by "BjornPrime (via GitHub)" <gi...@apache.org>.
BjornPrime commented on code in PR #27364:
URL: https://github.com/apache/beam/pull/27364#discussion_r1254526882


##########
sdks/python/apache_beam/io/gcp/gcsio.py:
##########
@@ -203,6 +203,10 @@ def delete_batch(self, paths):
     Args:
       paths: List of GCS file path patterns in the form gs://<bucket>/<name>,
              not to exceed MAX_BATCH_OPERATION_SIZE in length.
+
+    Returns: List of tuples of (path, exception) in the same order as the

Review Comment:
   I believe this just restores the return behavior from before my recent changes to gcsio. Replicating the batch return behavior was the only remaining stumbling block to merging that, so we separated it out, merged the rest, and milestoned this for release in 2.50 so by the time the refurbished IO is released, the return behavior should be back to how it was.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org