You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/01 21:39:45 UTC
[GitHub] [hudi] CTTY opened a new pull request, #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
CTTY opened a new pull request, #5734:
URL: https://github.com/apache/hudi/pull/5734
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
Fix hudi-cli rollback failure with rollbackUsingMarkers option
## Brief change log
*(for example:)*
- Call the correct method in SparkMain when rollbackUsingMarkers option is provided
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] CTTY commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
CTTY commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1160808240
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1161159695
+1，i'm gonna merge it because the failing IT tests has no relationship with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1144202966
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd314b74eabaf187ce073ec938a6a38e502288f1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] CTTY commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
CTTY commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1159598872
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1159603505
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "1159598872",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d0a0775ad184f254cb2eee3a0a0e4f753a6c303a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] CTTY commented on a diff in pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
CTTY commented on code in PR #5734:
URL: https://github.com/apache/hudi/pull/5734#discussion_r887444565
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -451,7 +451,7 @@ private static int doBootstrap(JavaSparkContext jsc, String tableName, String ta
}
private static int rollback(JavaSparkContext jsc, String instantTime, String basePath, Boolean rollbackUsingMarkers) throws Exception {
- SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers);
+ SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers, false);
Review Comment:
This call here is supposed to call method at L529 [here](https://github.com/apache/hudi/blob/cd314b74eabaf187ce073ec938a6a38e502288f1/hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java#L529), but currently it's calling method at L534 [here](https://github.com/apache/hudi/blob/cd314b74eabaf187ce073ec938a6a38e502288f1/hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java#L534), and it's passing `rollbackUsingMarkers` as `lazyCleanPolicy`, which would cause issues when `rollbackUsingMarkers` is passed in hudi-cli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #5734:
URL: https://github.com/apache/hudi/pull/5734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1160814766
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "1159598872",
"triggerType" : "MANUAL"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "1160236753",
"triggerType" : "MANUAL"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1160808240",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d0a0775ad184f254cb2eee3a0a0e4f753a6c303a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1160240729
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "1159598872",
"triggerType" : "MANUAL"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1160236753",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d0a0775ad184f254cb2eee3a0a0e4f753a6c303a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #5734:
URL: https://github.com/apache/hudi/pull/5734#discussion_r893991532
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -451,7 +451,7 @@ private static int doBootstrap(JavaSparkContext jsc, String tableName, String ta
}
private static int rollback(JavaSparkContext jsc, String instantTime, String basePath, Boolean rollbackUsingMarkers) throws Exception {
- SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers);
+ SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers, false);
Review Comment:
Let's try to see if we can add a test please. would be helpful in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1144281635
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd314b74eabaf187ce073ec938a6a38e502288f1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1159593976
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0a0775ad184f254cb2eee3a0a0e4f753a6c303a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1160245450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "1159598872",
"triggerType" : "MANUAL"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "1160236753",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d0a0775ad184f254cb2eee3a0a0e4f753a6c303a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1160236753
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] CTTY commented on a diff in pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
CTTY commented on code in PR #5734:
URL: https://github.com/apache/hudi/pull/5734#discussion_r888425889
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -451,7 +451,7 @@ private static int doBootstrap(JavaSparkContext jsc, String tableName, String ta
}
private static int rollback(JavaSparkContext jsc, String instantTime, String basePath, Boolean rollbackUsingMarkers) throws Exception {
- SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers);
+ SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers, false);
Review Comment:
We can but adding a test is non-trival work, as it involves another option introduced in this [PR](https://github.com/apache/hudi/pull/5158/files)
We might want to file a seperate jira to add a test.
Apart from that, I tested this fix manually on AWS EMR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1144200164
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd314b74eabaf187ce073ec938a6a38e502288f1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] CTTY commented on a diff in pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
CTTY commented on code in PR #5734:
URL: https://github.com/apache/hudi/pull/5734#discussion_r901972537
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -451,7 +451,7 @@ private static int doBootstrap(JavaSparkContext jsc, String tableName, String ta
}
private static int rollback(JavaSparkContext jsc, String instantTime, String basePath, Boolean rollbackUsingMarkers) throws Exception {
- SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers);
+ SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers, false);
Review Comment:
I've added a test for this change. Could you take a look again? Also I've noticed a flink IT test has been failing: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=9375&view=logs&j=3b6e910d-b98f-5de6-b9cb-1e5ff571f5de&t=30b5aae4-0ea0-5566-42d0-febf71a7061a&l=120490
I don't think my change would affect this test, but not sure if this is a flaky test, could you also take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1159603187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1159598872",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d0a0775ad184f254cb2eee3a0a0e4f753a6c303a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1159581536
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd314b74eabaf187ce073ec938a6a38e502288f1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042)
* d0a0775ad184f254cb2eee3a0a0e4f753a6c303a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1159581104
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd314b74eabaf187ce073ec938a6a38e502288f1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042)
* d0a0775ad184f254cb2eee3a0a0e4f753a6c303a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5734:
URL: https://github.com/apache/hudi/pull/5734#issuecomment-1160817941
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9042",
"triggerID" : "cd314b74eabaf187ce073ec938a6a38e502288f1",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"triggerType" : "PUSH"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "1159598872",
"triggerType" : "MANUAL"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "1160236753",
"triggerType" : "MANUAL"
}, {
"hash" : "d0a0775ad184f254cb2eee3a0a0e4f753a6c303a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375",
"triggerID" : "1160808240",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d0a0775ad184f254cb2eee3a0a0e4f753a6c303a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9375)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5734:
URL: https://github.com/apache/hudi/pull/5734#discussion_r887418538
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -451,7 +451,7 @@ private static int doBootstrap(JavaSparkContext jsc, String tableName, String ta
}
private static int rollback(JavaSparkContext jsc, String instantTime, String basePath, Boolean rollbackUsingMarkers) throws Exception {
- SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers);
+ SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers, false);
Review Comment:
What is this patch fixing for ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5734:
URL: https://github.com/apache/hudi/pull/5734#discussion_r887551587
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -451,7 +451,7 @@ private static int doBootstrap(JavaSparkContext jsc, String tableName, String ta
}
private static int rollback(JavaSparkContext jsc, String instantTime, String basePath, Boolean rollbackUsingMarkers) throws Exception {
- SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers);
+ SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers, false);
Review Comment:
Is there any possibility we write a test here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org