You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/12/28 01:39:14 UTC
[GitHub] [incubator-pinot] imsut opened a new pull request #6388: TE: exclude logback-classic from dependency
imsut opened a new pull request #6388:
URL: https://github.com/apache/incubator-pinot/pull/6388
## Description
Update pom.xml to exclude `logback-classic` from dependency.
Without this change, "thirdeye-dashboard" picks up `ch.qos.logback.classic.util.ContextSelectorStaticBinder` as slf4j backend and ignores "log4j2.xml".
Console log when running "run-frontend.sh" w/o this change.
```
$ ./run-frontend.sh
*******************************************************
Launching ThirdEye Dashboard in demo mode
*******************************************************
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/Users/ken/workspace/apache/incubator-pinot/thirdeye/thirdeye-dashboard/target/libs/logback-classic-1.2.3.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/Users/ken/workspace/apache/incubator-pinot/thirdeye/thirdeye-dashboard/target/libs/log4j-slf4j-impl-2.12.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [ch.qos.logback.classic.util.ContextSelectorStaticBinder]
...
```
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
N/A
## Documentation
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on pull request #6388: TE: exclude logback-classic from dependency
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on pull request #6388:
URL: https://github.com/apache/incubator-pinot/pull/6388#issuecomment-819356742
Close this as thirdeye repo is moved to https://github.com/project-thirdeye/thirdeye
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 closed pull request #6388: TE: exclude logback-classic from dependency
Posted by GitBox <gi...@apache.org>.
fx19880617 closed pull request #6388:
URL: https://github.com/apache/incubator-pinot/pull/6388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org