You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/08/30 09:45:31 UTC
[GitHub] [brooklyn-ui] algairim opened a new pull request #271: Always download referenced resources in the button directive
algairim opened a new pull request #271:
URL: https://github.com/apache/brooklyn-ui/pull/271
Signed-off-by: Mykola Mandra <my...@cloudsoft.io>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana merged pull request #271: Always download referenced resources if configured so
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #271:
URL: https://github.com/apache/brooklyn-ui/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #271: WIP Always download referenced resources in the button directive
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #271:
URL: https://github.com/apache/brooklyn-ui/pull/271#discussion_r698349796
##########
File path: ui-modules/utils/br-core/button/button.html
##########
@@ -16,4 +16,4 @@
specific language governing permissions and limitations
under the License.
-->
-<a ng-href="{{link}}" role="button" class="btn btn-default" ng-class="type" ng-click="click()" ng-transclude></a>
\ No newline at end of file
+<a ng-href="{{link}}" role="button" class="btn btn-default" ng-class="type" ng-click="click()" ng-transclude download></a>
Review comment:
Just noticed that not every button is a download button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #271: WIP Always download referenced resources in the button directive
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #271:
URL: https://github.com/apache/brooklyn-ui/pull/271#discussion_r698349446
##########
File path: ui-modules/utils/br-core/button/button.html
##########
@@ -16,4 +16,4 @@
specific language governing permissions and limitations
under the License.
-->
-<a ng-href="{{link}}" role="button" class="btn btn-default" ng-class="type" ng-click="click()" ng-transclude></a>
\ No newline at end of file
+<a ng-href="{{link}}" role="button" class="btn btn-default" ng-class="type" ng-click="click()" ng-transclude download></a>
Review comment:
Requires a better improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana merged pull request #271: Always download referenced resources if configured so
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #271:
URL: https://github.com/apache/brooklyn-ui/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana merged pull request #271: Always download referenced resources if configured so
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #271:
URL: https://github.com/apache/brooklyn-ui/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org