You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ravi Prakash (JIRA)" <ji...@apache.org> on 2016/05/05 21:23:12 UTC
[jira] [Commented] (HADOOP-13051) Add Glob unit test for special
characters
[ https://issues.apache.org/jira/browse/HADOOP-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273115#comment-15273115 ]
Ravi Prakash commented on HADOOP-13051:
---------------------------------------
Thanks for the patch Harsh and the review John! Committed to trunk.
> Add Glob unit test for special characters
> -----------------------------------------
>
> Key: HADOOP-13051
> URL: https://issues.apache.org/jira/browse/HADOOP-13051
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: HADOOP-13051.000.patch
>
>
> On {{branch-2}}, the below is the (incorrect) behaviour today, where paths with special characters get dropped during globStatus calls:
> {code}
> bin/hdfs dfs -mkdir /foo
> bin/hdfs dfs -touchz /foo/foo1
> bin/hdfs dfs -touchz $'/foo/foo1\r'
> bin/hdfs dfs -ls '/foo/*'
> -rw-r--r-- 3 harsh supergroup 0 2016-04-22 17:35 /foo/foo1
> -rw-r--r-- 3 harsh supergroup 0 2016-04-22 17:35 /foo/foo1^M
> bin/hdfs dfs -ls '/foo/*'
> -rw-r--r-- 3 harsh supergroup 0 2016-04-22 17:35 /foo/foo1
> {code}
> Whereas trunk has the right behaviour, subtly fixed via the pattern library change of HADOOP-12436:
> {code}
> bin/hdfs dfs -mkdir /foo
> bin/hdfs dfs -touchz /foo/foo1
> bin/hdfs dfs -touchz $'/foo/foo1\r'
> bin/hdfs dfs -ls '/foo/*'
> -rw-r--r-- 3 harsh supergroup 0 2016-04-22 17:35 /foo/foo1
> -rw-r--r-- 3 harsh supergroup 0 2016-04-22 17:35 /foo/foo1^M
> bin/hdfs dfs -ls '/foo/*'
> -rw-r--r-- 3 harsh supergroup 0 2016-04-22 17:35 /foo/foo1
> -rw-r--r-- 3 harsh supergroup 0 2016-04-22 17:35 /foo/foo1^M
> {code}
> (I've placed a ^M explicitly to indicate presence of the intentional hidden character)
> We should still add a simple test-case to cover this situation for future regressions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org