You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "sveneld (via GitHub)" <gi...@apache.org> on 2026/09/03 08:07:08 UTC
[PR] THRIFT-1941: Add PHP serializer regression coverage [thrift]
sveneld opened a new pull request, #3794:
URL: https://github.com/apache/thrift/pull/3794
## Summary
- add a PHP unit regression test for the accelerated `TBinarySerializer::deserialize()` path
- assert that the synthetic message prefix written during deserialize is readable inside the extension callback path
- lock in the `flush()` behavior that fixes the historical buffered-transport failure described in `THRIFT-1941`
## Testing
- `docker run --rm -v /home/v.panivko/github/thrift:/thrift -w /thrift thrift-php-dev:local vendor/bin/phpunit -c lib/php/phpunit.xml lib/php/test/Unit/Lib/Serializer/TBinarySerializerTest.php`
Generated-by: OpenAI Codex GPT-5 <no...@openai.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-1941: Add PHP serializer regression coverage [thrift]
Posted by "sveneld (via GitHub)" <gi...@apache.org>.
sveneld merged PR #3794:
URL: https://github.com/apache/thrift/pull/3794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org