You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/09 02:09:15 UTC

[GitHub] [hbase] Joseph295 commented on a change in pull request #2035: HBASE-24663 Add procedure process time statistics UI

Joseph295 commented on a change in pull request #2035:
URL: https://github.com/apache/hbase/pull/2035#discussion_r451923319



##########
File path: hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Histogram.java
##########
@@ -55,4 +55,10 @@
   @InterfaceAudience.Private
   Snapshot snapshot();
 
+  long[] getQuantiles(double[] quantiles);

Review comment:
       snapshot() will  be better, but the implementation will reset the data before, which makes no senses for histogram metrics. I haven't gotten the reason.Another thing is the interfaces in Histogram are not enough? There are getMin, getMax, usually we need quantiles?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org